Update helpers for TS 3.9 (Update __importStar, __exportStar, add __createBinding) #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rbuckton we need this reviewed, iterated if need be, and in for the 3.9 release, so a review (and merge if OK) would be appreciated. |
This was referenced May 5, 2020
rbuckton
approved these changes
May 5, 2020
|
Looks good. Should @DanielRosenwasser push up a new tslib release now or is there more we need to get in to this? |
|
@DanielRosenwasser was planning on making a release with the new licence; weather he's already done that or not, I do not know. |
evmar
reviewed
May 6, 2020
| @@ -34,3 +34,4 @@ export declare function __importStar<T>(mod: T): T; | |||
| export declare function __importDefault<T>(mod: T): T | { default: T }; | |||
| export declare function __classPrivateFieldGet<T extends object, V>(receiver: T, privateMap: { has(o: T): boolean, get(o: T): V | undefined }): V; | |||
| export declare function __classPrivateFieldSet<T extends object, V>(receiver: T, privateMap: { has(o: T): boolean, set(o: T, value: V): any }, value: V): V; | |||
| export declare function __createBinding(object: object, target: object, key: PropertyKey, objectKey?: PropertyKey); | |||
There was a problem hiding this comment.
🤦 @rbuckton CI on this repo when
There was a problem hiding this comment.
You can think of me as a CI with extremely high variance -- sometimes you get feedback in a day, other times three months. :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidates #78 and #89