Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Campaign IDs #1408

Merged
merged 14 commits into from
Jun 24, 2024
Merged

Add Campaign IDs #1408

merged 14 commits into from
Jun 24, 2024

Conversation

JavierMatosD
Copy link
Contributor

This PR is adding some campaign ids to some of our commands. Rather than doing all at once, I'm hoping to break things down into chunks in separate PRs. The aim for this PR is to ensure the Campaign IDs are working by testing out a few links.

include/vcpkg/base/message-data.inc.h Show resolved Hide resolved
@JavierMatosD
Copy link
Contributor Author

I think we should ship this before setting up telemetry for this. The reason being that we don't even know whether or not people will click on these links. We could be investing resources into setting up telemetry for no reason.

@BillyONeal BillyONeal merged commit dfc8c0f into microsoft:main Jun 24, 2024
5 checks passed
@BillyONeal
Copy link
Member

Thanks!

BillyONeal added a commit to BillyONeal/vcpkg-tool that referenced this pull request Jun 26, 2024
Between:
* microsoft#1210
* microsoft#1408

This adds the URL to normal registries use of this but doesn't repeat the URL over and over again in ci-verify-versions.
BillyONeal added a commit that referenced this pull request Jun 27, 2024
Between:
* #1210
* #1408

This adds the URL to normal registries use of this but doesn't repeat the URL over and over again in ci-verify-versions.
@JavierMatosD JavierMatosD deleted the add_campaign_ids branch July 20, 2024 19:54
BillyONeal added a commit to BillyONeal/vcpkg-tool that referenced this pull request Jul 24, 2024
* In microsoft#1455 I missed making absolute lowercase.
* In microsoft#1408 a lot of whitespace was missed leading to output like

error: building vtk:x64-linux failed with: BUILD_FAILEDSee https://learn.microsoft.com/vcpkg/troubleshoot/build-failures?WT.mc_id=vcpkg_inproduct_cli for more information.
BillyONeal added a commit that referenced this pull request Jul 24, 2024
* In #1455 I missed making absolute lowercase.
* In #1408 a lot of whitespace was missed leading to output like

error: building vtk:x64-linux failed with: BUILD_FAILEDSee https://learn.microsoft.com/vcpkg/troubleshoot/build-failures?WT.mc_id=vcpkg_inproduct_cli for more information.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants