Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make print_plan actually print. #1415

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Make print_plan actually print. #1415

merged 1 commit into from
Jul 23, 2024

Commits on Jun 7, 2024

  1. Make print_plan actually print. 

    print_plan does 2 things. First, it formats the action plan and prints it to the console. Second, if there were removals in the plan and the intent is not recursive, it terminates vcpkg. A function named 'print' should not be terminating vcpkg.

Moreover, only one caller actually desires this terminating behavior: the install command. All other users hard coded a value of true.

This suggests that the decision to terminate should be localized to that one caller rather than spread over everything.
    @BillyONeal
    BillyONeal committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    8c13e91 View commit details
    Browse the repository at this point in the history