-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android prefab broken due to emscripten support #12359
Comments
cc @MoAlyousef |
I could remove the env checks in the cmake script. I don't see why vcpkg would check for it during an export for another triplet. |
This looks like a bug in the prefab exporter; it should not be iterating through all available triplets and attempting to "divine" the correct ones: vcpkg/toolsrc/src/vcpkg/export.prefab.cpp Line 276 in de70813
Instead, the user should explicitly label each of the required architectures; perhaps via individual options:
We'd be happy to review a PR fixing this! +@atkawa7 as the original author |
Note that if you do "work around" it in this way, or specify something like this, it still fails:
I've tracked down that the |
@ras0219 @ras0219-msft I don't have time to look into this but based on my previous conversation with @strega-nil. She advised I do not pre-define triplets since users might define their own custom ones hence ended up loading available triplets. Since an environment variable is missing for
Originally posted by @strega-nil in #10271 (comment). |
Additionally, it shouldn't require all of the triplets: you can build an aar/prefab with as few architectures as you wish. |
Are there any news or possible solutions? |
Describe the bug
It is currently not possible to create android prefabs (AAR) because of the emscripten support.
During the export command vcpkg tries to extract triplet information by running cmake with the toolchain file. However, the toolchain for emscripten returns a FATAL_ERROR in case emscripten is not present/installed. This results in vcpkg aborting.
A fix for this particular issue is to remove the emscripten present checks in the triplet, but this may break other things?
Environment
To Reproduce
Steps to reproduce the behavior:
2.1 Add android triplets
2.2
./vcpkg install jsoncpp:arm-android jsoncpp:arm64-android jsoncpp:x64-android jsoncpp:x86-android
2.3
./vcpkg export --triplet arm64-android jsoncpp --prefab --prefab-debug
Expected behavior
Should create the AAR prefab for jsoncpp
Failure logs
Additional context
Add any other context about the problem here.
The first commit where this problem is present is the merge of the emscripten PR: a6257ac
The text was updated successfully, but these errors were encountered: