Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VSTHRD114: Do not return null from non-async Task method #596

Merged
merged 14 commits into from
Apr 19, 2020
Merged

VSTHRD114: Do not return null from non-async Task method #596

merged 14 commits into from
Apr 19, 2020

Commits on Mar 27, 2020

  1. VSTHRD112: Do not return null from non-async Task method

    @Evangelink
    Evangelink committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    d97aae5 View commit details
    Browse the repository at this point in the history

  2. Fix broken tests

    @Evangelink
    Evangelink committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    59b7c8f View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2020

  1. Merge branch 'master' into task-return-null

    @Evangelink
    Evangelink committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    145d9a1 View commit details
    Browse the repository at this point in the history

  2. Address review comments

    @Evangelink
    Evangelink committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    4018631 View commit details
    Browse the repository at this point in the history

  3. Rename analyzer + fix styling error

    @Evangelink
    Evangelink committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    e8e21a7 View commit details
    Browse the repository at this point in the history

  4. Add code fix

    @Evangelink
    Evangelink committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    a985e83 View commit details
    Browse the repository at this point in the history

  5. Add sharwell's lightup for nullables

    @Evangelink
    Evangelink committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    b7bed63 View commit details
    Browse the repository at this point in the history

  6. Update to roslyn 3.3 to allow nullable enable in tests

    @Evangelink
    Evangelink committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    7506a3d View commit details
    Browse the repository at this point in the history

  7. Do not report on nullable enable context

    @Evangelink
    Evangelink committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    ac398e4 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2020

  1. Apply suggestions from code review 

    Co-Authored-By: Sam Harwell <[email protected]>
    @Evangelink @sharwell
    Evangelink and sharwell committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    3ec3615 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2020

  1. Address review comments

    @Evangelink
    Evangelink committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    63f5194 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into task-return-null

    @Evangelink
    Evangelink committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    5b8b2b8 View commit details
    Browse the repository at this point in the history

  3. Fix merge conflicts

    @Evangelink
    Evangelink committed Apr 16, 2020
    Configuration menu
    Copy the full SHA
    d3f9efc View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2020

  1. Remove light-ups to get tests working 

    I don't so much care that someone with NRT will get duplicate diagnostics when returning null.
    @AArnott
    AArnott committed Apr 18, 2020
    Configuration menu
    Copy the full SHA
    d827da7 View commit details
    Browse the repository at this point in the history