Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FileSystem proposed protocol spec & documentation #782

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

NTaylorMullen
Copy link
Member

  • Added the spec itself in addition to adding the protocol types, requests, notifications and expansions of that in the API.
  • Prior to updating implementation figured this was a good first step to ensure I was setting things up correctly.

Copy link
Contributor

@rcjsuen rcjsuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the pull request on GitHub I can see a lot formatting inconsistencies.

protocol/src/common/proposed.fileSystemProvider.ts Outdated Show resolved Hide resolved
protocol/src/common/proposed.fileSystemProvider.ts Outdated Show resolved Hide resolved
protocol/src/common/proposed.fileSystemProvider.ts Outdated Show resolved Hide resolved
protocol/src/common/proposed.fileSystemProvider.ts Outdated Show resolved Hide resolved
protocol/src/common/proposed.fileSystemProvider.ts Outdated Show resolved Hide resolved
protocol/src/common/proposed.fileSystemProvider.ts Outdated Show resolved Hide resolved
- Added the spec itself in addition to adding the protocol types, requests, notifications and expansions of that in the API.
- Prior to updating implementation figured this was a good first step to ensure I was setting things up correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants