Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for folders with multiple devcontainer.json files #7548

Closed
chrmarti opened this issue Nov 18, 2022 · 5 comments
Closed

Support for folders with multiple devcontainer.json files #7548

chrmarti opened this issue Nov 18, 2022 · 5 comments
Assignees
Labels
containers Issue in vscode-remote containers on-testplan plan-item A plan item
Milestone

Comments

@chrmarti
Copy link
Contributor

chrmarti commented Nov 18, 2022

The dev containter spec has update to allow for multiple devcontainer.json files to exist in a sub-folder of .devcontainer in the root of the workspace. This has been implemented in Codespaces, but not the Dev Containers extension. This issue tracks adding that support.

@eitsupi
Copy link

eitsupi commented Dec 15, 2022

I think this feature is really great. I would rather use multiple small containers than have one huge one in monorepo.

@sterling000
Copy link

Really really need this, my current client has a mono-repo where the src folder is treated like the "root" folder for their django project, and then when they added react components they are within a subfolder of that src folder, and the context needs to be the project root, so i need to have the .devcontainer.json files be separate for team members who work in django or work in node but sharing the same workspace. Need to support multiple devcontainer.json files with different docker images and extensions etc but with the exact same volume mounts and workspaces so that all their existing shell scripts work without rewriting all the references.

@sterling000
Copy link

I need to be able to open the root folder and select among multiple devcontainer.json files, if i ave to use "Open Folder in Container" and select the subfolder that has the devcontainer.json file in it then even if the container is created and the volume is mapped, the wrong folder is opened because now it's limited to just the subfolder but i want the parent folder to be the one opened in vscode

@sterling000
Copy link

I would be open to having a docker-compose file in the root of the project, but when i run "Open folder in dev container" or "reopen folder in container" it does not currently detect my .devcontainer/django/devcontainer.json file or my .devcontainer/node/devcontainer.json file and asks me to create a new single devcontainer.json file instead of selecting from the existing ones.

@chrmarti
Copy link
Contributor Author

Implemented for local folders, tracking support for "Clone in Volume" with #7879.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
containers Issue in vscode-remote containers on-testplan plan-item A plan item
Projects
None yet
Development

No branches or pull requests

3 participants