Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New theme matching and new tokens format #18317

Closed
26 tasks done
alexdima opened this issue Jan 9, 2017 · 1 comment
Closed
26 tasks done

New theme matching and new tokens format #18317

alexdima opened this issue Jan 9, 2017 · 1 comment
Assignees
@alexdima
Labels
feature-request Request for new features or functionality plan-item VS Code - planned item for upcoming
Milestone
January 2017

Comments

@alexdima
Copy link
Member

alexdima commented Jan 9, 2017 •
edited

Adopt new theme matching support available in vscode-textmate.

DONE:

  • Common
    • adopt new tokens representation in model & co.
    • remove paranoia check in ViewLineToken
    • remove model.getMode() and model.getModeId()
    • rename LanguageIdentifier.sid and LanguageIdentifier.iid
    • remove token class name from every token
  • Standalone editor
    • generate new tokens format in monarch and manual tokenizers
    • align standalone languages tokenizers to generate classic style tokens
    • clean up standalone tokens css rules and move them to JS
    • match tokens using theme rules in JS for monarch and manual tokenizers
    • expose new tokenization API in standalone editor
    • adopt standalone languages tests for tokenization
    • validate new tokenization using tokenization.html standalone test
    • allow for theme switching in standaloneColorService
    • allow for theme customization in standalone editor
    • check editor with bootstrap css (created follow up task)
    • add inspect tokens command
  • adopt new vscode-textmate
    • publish vscode-textmate
    • get theme information to vscode-textmate
    • reimplement theme integration tests
    • allow for theme switching
    • handle encountered languages while tokenizing
    • remove dom layer breaker from TMSyntax.ts
    • add inspect tokens command
@alexdima alexdima added feature-request Request for new features or functionality plan-item VS Code - planned item for upcoming labels Jan 9, 2017
@alexdima alexdima self-assigned this Jan 9, 2017
@alexdima alexdima added this to the January 2017 milestone Jan 9, 2017
@egamma egamma mentioned this issue Jan 9, 2017
Closed
56 tasks
@alexdima alexdima mentioned this issue Jan 9, 2017
Closed
2 tasks
@alexdima
Copy link
Member Author

alexdima commented Jan 9, 2017

Test plan item: #18318

@alexdima alexdima closed this as completed Jan 9, 2017
@Wosi Wosi mentioned this issue Jan 10, 2017
Closed
@ramya-rao-a ramya-rao-a mentioned this issue Jan 16, 2017
Open
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
feature-request Request for new features or functionality plan-item VS Code - planned item for upcoming
Projects
None yet
Milestone
January 2017
Development

No branches or pull requests
1 participant
@alexdima