Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test new theme matching and new tokens format #18318

Closed
2 tasks done
alexdima opened this issue Jan 9, 2017 · 5 comments
Closed
2 tasks done

Test new theme matching and new tokens format #18318

alexdima opened this issue Jan 9, 2017 · 5 comments

Comments

@alexdima
Copy link
Member

alexdima commented Jan 9, 2017

Cmplexity: 4

Plan item: #18317

The changes are heavily covered through unit tests, but there are some integration things that might not work, so please check:

  • create or change a grammar to emit a scope name that contains < or > or &. Please check that these strings do not make it into the editor HTML rendering and also not into the Developer: Inspect TM Scopes widget
  • change an editor contribution (in code) to add an inline decoration class name (e.g. link contribution) that contains < or > or &. Please check that these strings do not make it into the editor HTML rendering.
  • check that changing a color theme to X produces the same colorization as loading the workbench fresh with the theme X (i.e. caches are correctly cleared)
  • open some different files in our most popular languages and in some of the most popular themes. Please compare with the previous stable version, and if you spot differences validate those differences are OK via the Developer: Inspect TM Scopes widget
@smlombardi
Copy link

Is there documentation for this new tokens format for theme developers? My theme is no longer coloring items as intended after 1.9.0 insider 2017-01-10T09:15:59.757Z.

@jrieken jrieken removed their assignment Jan 24, 2017
@chrmarti
Copy link
Contributor

@smlombardi Could you open a bug report for your case?

@chrmarti
Copy link
Contributor

Verified using, e.g., "name": "comment.line.doubl>e-slash.js" in JavaScript.tmLanguage.json does not corrupt the output:
screen shot 2017-01-24 at 3 40 22 pm

@chrmarti
Copy link
Contributor

Also verified that changing the class name detected-link in links.ts and stylesContributions.ts to include those characters does not let these show up in the editor. I see them in the DOM properly escaped.

@chrmarti
Copy link
Contributor

Hope that's according to the test description. Also tested the other two points and filed issues.

@chrmarti chrmarti removed their assignment Jan 25, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants