-
Notifications
You must be signed in to change notification settings - Fork 28.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add token background colors to themes #212294
base: main
Are you sure you want to change the base?
Add token background colors to themes #212294
Conversation
|
Thank you! While this is straight-forward to implement, I have always had 2 major concerns why I didn't implement this:
|
With 1291b04 the token backgrounds go below the decoration layer, so selection etc are always visible. Here's the plain case. Cursor is at the start of line 17. The light blue is the line highlight. Tokens with backgrounds are on lines 12-14. Here's with word highlight over the background. And with the selection over the background. Note that the line highlight is removed whenever there's a selection.
Good point. Perhaps a flag on the theme could control whether backgrounds are used in rules. |
vary the intensity in some other way, e.g. invert the colors, or intensify them, or do a color shift; maybe give a new option mode how people want selection be displayed ("invert", "shift", "intensify", "blur" whatever).
When the themes had no token background colors defined before, then nothing changes. What about an option "NoBackgroundColor" - or, vice versa, "WithBackgroundColor" for those who want to intentionally enable that feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code looks good. I would like to have this feature also.
Add support for background colors to theme rules.
Closes #3429.
I did this before noticing #3429. Maybe helps someone wanting to patch their own version.
Example