Skip to content

Commit

Permalink
Downgrade msbuild sdk (#4864)
Browse files Browse the repository at this point in the history
* Revert "Update global.json (#4858)"

This reverts commit bf35e8a.

* Downgrade dotnet and msbuild-sdk

* Downgrade dotnet and msbuild-sdk

* Ignore new tests, and downgrade SDK
  • Loading branch information
nohwnd committed Jan 30, 2024
1 parent 926f46c commit d617595
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
6 changes: 3 additions & 3 deletions global.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"sdk": {
"version": "9.0.100-alpha.1.24073.1",
"version": "9.0.100-alpha.1.23615.4",
"rollForward": "minor",
"allowPrerelease": false,
"architecture": "x64"
Expand All @@ -27,9 +27,9 @@
"vs": {
"version": "17.8.0"
},
"xcopy-msbuild": "17.8.3",
"xcopy-msbuild": "17.8.1-2",
"vswhere": "2.2.7",
"dotnet": "9.0.100-alpha.1.24073.1"
"dotnet": "9.0.100-alpha.1.23615.4"
},
"msbuild-sdks": {
"Microsoft.DotNet.Arcade.Sdk": "9.0.0-beta.24076.5"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,13 @@ namespace Microsoft.TestPlatform.AcceptanceTests;
/// Running dotnet test + csproj and using MSBuild for the output.
/// </summary>
[TestClass]
[Ignore(
"""
Ignored because we need to update to dotnet SDK 9.0.100-alpha.1.24073.1 or newer,
but that depends on newer version of MSBuild sdk that is not published yet, and so our build fails in Signing validation.
We need that upgrade because older SDK is hardcoding the same ENV variable that we are using to disable this functionality.
So when we patch the targets and build dll in the current SDK this new functionality is always disabled and we cannot test it with older SDK.
""")]
public class DotnetTestMSBuildOutputTests : AcceptanceTestBase
{
[TestMethod]
Expand Down

0 comments on commit d617595

Please sign in to comment.