Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't lose the stack when rethrowing exceptions from TestHost #1060

Merged
merged 1 commit into from
Sep 10, 2017
Merged

Don't lose the stack when rethrowing exceptions from TestHost #1060

merged 1 commit into from
Sep 10, 2017

Conversation

dfederm
Copy link
Member

@dfederm dfederm commented Sep 8, 2017

I'm seeing the following when trying to run vstest:

Microsoft (R) Test Execution Command Line Tool Version 15.5.0-dev
Copyright (c) Microsoft Corporation.  All rights reserved.

Starting test execution, please wait...
Testhost process exited with error: Unhandled Exception: System.IO.FileLoadException: Could not load file or assembly 'System.Threading.Thread, Version=4.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
   at Microsoft.VisualStudio.TestPlatform.TestHost.Program.Main(String[] args)

The strack trace for the exception is lost since it's not re-thrown properly.

@msftclas
Copy link

msftclas commented Sep 8, 2017

@dfederm,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@smadala
Copy link
Contributor

smadala commented Sep 9, 2017

@dotnet-bot Please test Windows_NT / Debug Build .

Copy link
Contributor

@singhsarab singhsarab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@codito codito merged commit ef95151 into microsoft:master Sep 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants