Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding log prefixkey to html logger #2204

Merged
merged 6 commits into from
Oct 23, 2019

Conversation

hvinett
Copy link
Contributor

@hvinett hvinett commented Sep 30, 2019

Description

Adding Log Prefix key for html logger

@@ -712,7 +712,6 @@ private void ValidateDateTimeInTrx(string trxFileName)

[TestMethod]
[DataRow("results")]
[DataRow("results.trx")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead add separate test, use data row with 2 arguments, one is the input and other expected output

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'.' is now like other alphabets right? do we really need another test case?

@singhsarab singhsarab merged commit 7ba379f into microsoft:master Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants