Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for discovery not working on Mac machines #2266

Merged
merged 2 commits into from
Dec 11, 2019
Merged

Fix for discovery not working on Mac machines #2266

merged 2 commits into from
Dec 11, 2019

Conversation

vagisha-nidhi
Copy link
Contributor

singhsarab
singhsarab reviewed Dec 10, 2019
View reviewed changes
src/Microsoft.TestPlatform.TestHostProvider/Hosting/DotnetTestHostManager.cs Outdated
@@ -259,6 +259,10 @@ public async Task<bool> LaunchTestHostAsync(TestProcessStartInfo testHostStartIn
if (!testHostExeFound)
{
var currentProcessPath = this.processHelper.GetCurrentProcessFileName();
if (testHostPath == string.Empty)
Copy link
Contributor

@singhsarab singhsarab Dec 10, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always use string.IsNullOrEmpty

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are you planning to test this ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also think about converging the two calls, if not possible I am okay with as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Converted to string.IsNullOrEmpty.
Also added an extra assert in existing test to veryfy testhost.dll path is determined in non windows scenario.

@vagisha-nidhi vagisha-nidhi merged commit 6d87e50 into microsoft:master Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@singhsarab singhsarab singhsarab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vagisha-nidhi @singhsarab