Use RunSettingsFilePath from project file when using dotnet test #2272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ViktorHofer You might want to take a look at this one. |
nohwnd
changed the title
ViktorHofer
reviewed
Dec 12, 2019
singhsarab
reviewed
Dec 12, 2019
test/Microsoft.TestPlatform.TestUtilities/IntegrationTestBase.cs
Outdated
Show resolved
Hide resolved
My understand was that we can point to any runsettings file anywhere on disk. Your description indicates that we can only point to a project level or solution level runsettings file. Is that correct? |
|
You can point to a file anywhere on the disk. The given examples use paths relative to a project or solution file, because I assumed that is what people will want to do most often. But you are not limited to do just that. You can use absolute path as well. |
|
Great, just wanted to make sure of that. Thanks. |
Uses the RunSettingsFilePath from project file when specified and falls back to the one specified in console, or the default setting if none are provided. The path to the settings file can be specified in multiple ways, for example as a path relative to the project file. This enables `dotnet test` to be invoked against the project file directly. ```xml <RunSettingsFilePath>$(ProjectDir)..\example.runsettings</RunSettingsFilePath> ``` Alternatively path can also be specified relatively to solution file, but that will only work when running dotnet test against the solution. On the other hand the setting will be the same in all projects. ```xml <RunSettingsFilePath>$(SolutionDir)\example.runsettings</RunSettingsFilePath> ``` Fixes microsoft#2265
nohwnd
force-pushed
the
use-runsettingsfilepath-from-project
branch
from
0f7e2d3
to
9b6a5f7
Compare
AbhitejJohn
approved these changes
Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses the RunSettingsFilePath from project file when specified and falls
back to the one specified in console, or the default setting if none are
provided.
The path to the settings file can be specified in multiple ways,
for example as a path relative to the project file. This enables
dotnet testto be invoked against the project file directly.Alternatively path can also be specified relatively to solution file, but that will
only work when running dotnet test against the solution. On the other hand the
setting will be the same in all projects.
The setting file can be overridden by specifying
--settingsfrom the command lineto give flexibility in providing alternative runsettings.
Related issue
Fixes #2265