Spelling / conventions and grammar fixes #2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 24, 2020 20:58
nohwnd
approved these changes
Feb 26, 2020
| @@ -6,106 +6,106 @@ | |||
|
|
|||
| namespace vstest.console.UnitTests.TestPlatformHelpers | |||
| { | |||
| using System; | |||
There was a problem hiding this comment.
what is going on in this file? was it using Tabs as spaces?
There was a problem hiding this comment.
hard to see from this view but the file has few thousand changes.
There was a problem hiding this comment.
Yes so i used the FixMixedTabs plugin to remove spaces with tabs, so looks like the plugin rewrites the whole cs file.
| @@ -3,842 +3,842 @@ | |||
|
|
|||
| namespace Microsoft.TestPlatform.Utilities.UnitTests | |||
| { | |||
| using System; | |||
There was a problem hiding this comment.
what is going on here? were there tabs instead of spaces?
There was a problem hiding this comment.
hard to see from this view but the file has few thousand changes.
There was a problem hiding this comment.
Yes so i used the FixMixedTabs plugin to remove spaces with tabs, so looks like the plugin rewrites the whole cs file.
|
Thanks, merged 👊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've corrected some spelling, grammar & whitespace errors i noticed while in this solution.
Please take a look. Hopefully it will improve the information conveyed to the user / dev.