Added method to look for new api in fakes datacollector #2339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nohwnd
reviewed
Mar 3, 2020
vritant24
force-pushed
the
dev/vrbhardw/fakes_dc_update
branch
from
bee8386
to
d443bee
Compare
nohwnd
approved these changes
Mar 5, 2020
|
@vritant24 is this ready to merge? the changes look good to go and I approved. If you will still work on it please mark it as work in progress by prefixing the name with |
|
Thanks for the review. I haven't yet merged it because the API on the other side hasn't been finalized and could possibly change. I'll update the PR name |
vritant24
changed the title
….Internal.TestPlatform.Extensions" nuget pacakge. This would mean that the TP vsix would not drop this dependency any more. The Fakes vsix that builds in the VSUT repo would be dropping it instead. For the TestPlatform tooling nuget however which ships with the Fakes dependency, I'm pulling in the latest from the vsunittesting myget feed and packaging that up.
nohwnd
reviewed
Mar 19, 2020
vritant24
force-pushed
the
dev/vrbhardw/fakes_dc_update
branch
from
4b88eb1
to
746bc17
Compare
AbhitejJohn
reviewed
Mar 20, 2020
| { | ||
| if (EqtTrace.IsInfoEnabled) | ||
| { | ||
| EqtTrace.Info("Failed to create newly implemented Fakes Configurator. Reason:{0} ", ex); |
There was a problem hiding this comment.
Does this show up in test platform diagnostic logs? Its probably used in some places in this file already but eqttrace logs IIRC are enabled and viewed differently from how we enable TP diagnostic logs in general.
…ckages from the dev build.
….Internal.TestPlatform.Extensions" nuget pacakge. This would mean that the TP vsix would not drop this dependency any more. The Fakes vsix that builds in the VSUT repo would be dropping it instead. For the TestPlatform tooling nuget however which ships with the Fakes dependency, I'm pulling in the latest from the vsunittesting myget feed and packaging that up.
…rosoft/vstest into dev/vrbhardw/fakes_dc_update
vritant24
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new Fakes Implementation will need a separate data collector for handling new scenarios that support .NET Core and Netstandard.
Previously,
TestWindow.FakesandVSTestwere making the same check and passing the same data collector configuration (FriendlyName,DataCollectorURi,DataCollectorAssemblyQualifiedName) toTestPlatform.Fakes. The creation of that config will be moved intoTestPlatform.Fakes, and the decision to use the new data collector will also be made there, which introduces the new API.