Support /TestCaseFilter and /Tests arguments at the same time #2371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also can't think about a reason why those parameters should not be compatible. Did you look into vstest-docs for any clues? |
|
@nohwnd yes I looked at the docs. They have a note saying they can't be used together but no context on why. Also it looks like the code has been like this since this repo was created. Not sure where the code lived before that. My guess is someone thought there is no need to specify both? |
nohwnd
approved these changes
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
My team has a scenario where I want to be able to pass both the /TestCaseFilter and the /Tests arguments at the same time (yes I know this doesn't seem like it should be necessary but we do have this use case). Right now vstest throws an exception if both are provided but I can't find a reason why. Digging through the code everything is piped through properly and works as expected.