Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed new configurator method name #2397

Merged
merged 4 commits into from
Apr 14, 2020

Conversation

vritant24
Copy link
Member

The old method name caused an ambiguous match exception since there is code in places we are still discovering that call the fakes configuration method with the name alone, not accounting for overloads.

Some more changes to variable names to explicitly show the difference

@vritant24 vritant24 changed the base branch from master to rel/16.6 April 13, 2020 18:35
@AbhitejJohn
Copy link
Contributor

@vritant24 : Please create a cherry-pick to master as well.

@vritant24 vritant24 merged commit 970d175 into rel/16.6 Apr 14, 2020
vritant24 added a commit that referenced this pull request Apr 14, 2020
* Changed new configurator method name

* added more robust heck for target framework

* default to FrameWork40

* fixed comment typo
nohwnd pushed a commit that referenced this pull request Apr 15, 2020
* Changed new configurator method name

* added more robust heck for target framework

* default to FrameWork40

* fixed comment typo
@Haplois Haplois deleted the dev/vrbhardw/fakes_dc_config_update branch January 27, 2021 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants