Add binaries to enable running Fakes in Net Core #2529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nohwnd
approved these changes
Aug 20, 2020
|
Looks good to me, we merge and insert into VS asap to see if we break stuff. |
AbhitejJohn
approved these changes
Aug 25, 2020
|
Validated VS scenario as well for net472 + netcoreapp3.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The .NetCore implementation for Fakes requires the CLRIE instrumentation engine, which is different from the .NET Framework implementation that uses Intellitrace.
This PR adds the necessary binaries that allow for Fakes tests to run through the TestPlatform package alone. The internal package used to provide the Fakes binaries has also been renamed and will constitute of all binaries that will be shared between Fakes in VS and TestPlatform.