Added support for new CC merging library for netstandard2.0 #2598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…117.6 (microsoft#2638) Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.SwaggerGenerator.MSBuild From Version 1.0.0-beta.20509.7 -> To Version 1.0.0-beta.20567.6 Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…u/vstest into copoiena/tp-cc-merging
fhnaseer
approved these changes
Nov 18, 2020
jakubch1
requested changes
Nov 18, 2020
jakubch1
reviewed
Nov 18, 2020
src/Microsoft.TestPlatform.Utilities/CodeCoverageDataAttachmentsHandler.cs
Outdated
Show resolved
Hide resolved
jakubch1
reviewed
Nov 18, 2020
src/Microsoft.TestPlatform.Utilities/CodeCoverageDataAttachmentsHandler.cs
Outdated
Show resolved
Hide resolved
jakubch1
reviewed
Nov 18, 2020
| // We took a dependency on Coverage.CoreLib.Net. In the unlikely case it cannot be | ||
| // resolved, this method call will throw an exception that will be caught and | ||
| // absorbed here. | ||
| this.MergeCodeCoverageFiles(files, cancellationToken); |
There was a problem hiding this comment.
It would be great to add IProgress to interface. @fhnaseer is this something that we can add? Does it make sense in our logic?
We can do it as new commits in both repos
There was a problem hiding this comment.
We can do this. Maybe in next version,
jakubch1
reviewed
Nov 18, 2020
test/Microsoft.TestPlatform.AcceptanceTests/TranslationLayerTests/CodeCoverageTests.cs
Outdated
Show resolved
Hide resolved
jakubch1
reviewed
Nov 19, 2020
jakubch1
reviewed
Nov 19, 2020
src/Microsoft.TestPlatform.Utilities/CodeCoverageDataAttachmentsHandler.cs
Outdated
Show resolved
Hide resolved
jakubch1
reviewed
Nov 19, 2020
src/Microsoft.TestPlatform.Utilities/CodeCoverageDataAttachmentsHandler.cs
Outdated
Show resolved
Hide resolved
jakubch1
reviewed
Nov 19, 2020
src/Microsoft.TestPlatform.Utilities/CodeCoverageDataAttachmentsHandler.cs
Outdated
Show resolved
Hide resolved
jakubch1
reviewed
Nov 19, 2020
src/Microsoft.TestPlatform.Utilities/CodeCoverageDataAttachmentsHandler.cs
Outdated
Show resolved
Hide resolved
fhnaseer
reviewed
Nov 19, 2020
src/Microsoft.TestPlatform.Utilities/Microsoft.TestPlatform.Utilities.csproj
Outdated
Show resolved
Hide resolved
fhnaseer
reviewed
Nov 19, 2020
fhnaseer
reviewed
Nov 19, 2020
Haplois
approved these changes
Nov 19, 2020
src/Microsoft.TestPlatform.Utilities/Microsoft.TestPlatform.Utilities.csproj
Outdated
Show resolved
Hide resolved
Haplois
approved these changes
Nov 19, 2020
jakubch1
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for new CC merging library