Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blame fix 32 bit hang dump #3043

Merged
merged 13 commits into from
Sep 9, 2021
Merged

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Sep 8, 2021

Description

When architecture of the dumped process differs from data collector, use minidump tool to run MiniDumpWriteDump from a process that has the correct bitness. This allows us to collect 32-bit hang dumps with visible callstacks, even when datacollector is 64-bit.

  • sign the executables

Related issue

Fix #3031

@nohwnd nohwnd marked this pull request as ready for review September 9, 2021 13:55
@nohwnd nohwnd requested a review from Haplois September 9, 2021 13:55
Copy link
Contributor

@Haplois Haplois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with comments.

src/DataCollectors/DumpMinitool/Program.cs Show resolved Hide resolved
@nohwnd nohwnd enabled auto-merge (squash) September 9, 2021 14:06
@nohwnd nohwnd merged commit b63abc4 into microsoft:main Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dotnet test in AzP captures 64-bit dump of 32-bit test runner process
2 participants