Enable code coverage when "Code Coverage;arg1=val1;arg2=val2" is provided in cli #3172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g.
Input:
--collect:"Code Coverage;CLRIEInstrumentationNetCore=true;CLRIEInstrumentationNetFramework=false"
Output:
<DataCollector friendlyName="Code Coverage" enabled="True">
<Configuration>
<CLRIEInstrumentationNetCore>true</CLRIEInstrumentationNetCore>
<CLRIEInstrumentationNetFramework>false</CLRIEInstrumentationNetFramework>
</Configuration>
</DataCollector>
…code-coverage build 20211111.1 Microsoft.Internal.CodeCoverage From Version 17.1.0-beta.21560.1 -> To Version 17.1.0-beta.21561.1
…d-8f377d0f6c72' into dev/fhnaseer/cc-commandline-config
…llowing command, dotnet test --collect:"Code Coverage;arg1=val1;arg2=val2"
| @@ -368,7 +368,12 @@ private List<string> AddArgs() | |||
| { | |||
| foreach (var arg in this.VSTestCollect) | |||
| { | |||
| if (arg.Equals("Code Coverage", StringComparison.OrdinalIgnoreCase)) | |||
| // Argument value could be CodeCoverage;a=b;c=d. | |||
There was a problem hiding this comment.
Suggested change
| // Argument value could be CodeCoverage;a=b;c=d. | |
| // Argument value could be 'Code Coverage;a=b;c=d'. |
Sanan07
approved these changes
Nov 16, 2021
Sanan07
reviewed
Nov 16, 2021
| // Split arg with ; and compare with the first token. | ||
| var tokens = arg.Split(';'); | ||
|
|
||
| if (arg.Equals("Code Coverage", StringComparison.OrdinalIgnoreCase) || |
There was a problem hiding this comment.
Maybe better to have const string with value = "Code Coverage" for correctness. If someone changes the value in future we will not get misspelling.
|
Hello @fhnaseer! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Sanan07
reviewed
Nov 16, 2021
| @@ -20,6 +20,7 @@ public class VSTestTask : Task, ICancelableTask | |||
| private VSTestForwardingApp vsTestForwardingApp; | |||
|
|
|||
| private const string vsTestAppName = "vstest.console.dll"; | |||
| private const string CodeCovergaeString = "Code Coverage"; | |||
There was a problem hiding this comment.
nit : misspelling
Suggested change
| private const string CodeCovergaeString = "Code Coverage"; | |
| private const string CodeCoverageString= "Code Coverage"; |
jakubch1
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable code coverage for the given command and will also append testAdapterPath to child dotnet process.
dotnet test --collect:"Code Coverage;arg1=val1"
will call
"dotnet" exec vstest.console.dll D:\TestProject\bin\Debug\net6.0\TestProject.dll --collect:"Code Coverage;arg1=val1" --testAdapterPath:D:\NuGetFeed\microsoft.codecoverage\16.9.4\build\netstandard1.0\