Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PublicAPI analyzer to all public projects #3205

Merged
merged 27 commits into from
Nov 30, 2021

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Nov 30, 2021

Description

Add Roslyn PublicAPI analyzer to all our public projects.

Related issue

Fix https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1271895

@nohwnd
Copy link
Member Author

nohwnd commented Nov 30, 2021

Please check:

That I did not forget the explicit reference to the analyzer package in any csproj.

There is no need to review the *.txt files. I validated that all Unshipped except for Microsoft.TestPlatform.ObjectModel\PublicAPI\PublicAPI.Unshipped.txt are empty. And we know that all Shipped have all the items an no extra items, because otherwise the build would fail.

@nohwnd nohwnd enabled auto-merge (squash) November 30, 2021 12:27
@nohwnd nohwnd disabled auto-merge November 30, 2021 13:04
Copy link
Contributor

@Haplois Haplois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a comment.

@Haplois Haplois merged commit 7f34994 into microsoft:main Nov 30, 2021
@nohwnd
Copy link
Member Author

nohwnd commented Nov 30, 2021

Acceptance tests were broken in unrelated place, because runtime could not be found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants