Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add diag log env variable #3275

Merged
merged 6 commits into from
Jan 25, 2022
Merged

Add diag log env variable #3275

merged 6 commits into from
Jan 25, 2022

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Jan 25, 2022

No description provided.

@nohwnd
Copy link
Member Author

nohwnd commented Jan 25, 2022

@MarcoRossignoli what do you think? Should we make it more configurable? (verbosity?) and change the naming some more?

@MarcoRossignoli
Copy link
Contributor

MarcoRossignoli commented Jan 25, 2022 •
edited
Loading

Looks good...but yep maybe we should add the verbosity(VSTEST_DIAGLOG_VERBOSITY optional and we can fallback to Verbose if TryParse fails) so we can ask to start with Error and after Verbose during the analysis, improving a bit the perf.

@nohwnd
Copy link
Member Author

nohwnd commented Jan 25, 2022 •
edited
Loading

Maybe I should only call it VSTEST_DIAG & VSTEST_DIAG_VERBOSITY to keep the same name as the argument?

@MarcoRossignoli
Copy link
Contributor

Maybe I should only call it VSTEST_DIAG & VSTEST_DIAG_VERBOSITY to keep the same name as the argument?

Yep sorry misread

@MarcoRossignoli
Copy link
Contributor

:shipit:

@nohwnd nohwnd marked this pull request as ready for review January 25, 2022 13:55
@MarcoRossignoli MarcoRossignoli enabled auto-merge (squash) January 25, 2022 15:44
MarcoRossignoli
MarcoRossignoli approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@MarcoRossignoli MarcoRossignoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Evangelink
Copy link
Member

@nohwnd I have added some minor comments, feel free to disregard them all.

@nohwnd nohwnd enabled auto-merge (squash) January 25, 2022 16:28
@nohwnd nohwnd merged commit 5e94a38 into microsoft:main Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink left review comments

@MarcoRossignoli MarcoRossignoli MarcoRossignoli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nohwnd @MarcoRossignoli @Evangelink