Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable even more rules #3356

Merged
merged 11 commits into from
Feb 12, 2022
Merged

Conversation

Evangelink
Copy link
Member

@MarcoRossignoli MarcoRossignoli enabled auto-merge (squash) February 12, 2022 13:04
@MarcoRossignoli
Copy link
Contributor

MarcoRossignoli commented Feb 12, 2022

we're missing only the null ref annotations...maybe we can start for new files/types(file context) and put some effort project by project...it could be a long task.

@Evangelink
Copy link
Member Author

I have a branch for it but that's pretty big effort. One solution could be to go with enable nullable and annotate all existing file with the disable so that every new added file follows nullable pattern and we could work on enabling it partially on existing files at a slower pace.

@Evangelink
Copy link
Member Author

@nohwnd Is it ok to squash and merge here?

@MarcoRossignoli MarcoRossignoli merged commit 2032c7b into microsoft:main Feb 12, 2022
@Evangelink Evangelink deleted the even-more-rules branch February 12, 2022 15:58
@MarcoRossignoli
Copy link
Contributor

I have a branch for it but that's pretty big effort. One solution could be to go with enable nullable and annotate all existing file with the disable so that every new added file follows nullable pattern and we could work on enabling it partially on existing files at a slower pace.

I think it's good...it's a great improvement anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants