fix same file access exception

[ntovas]

The current pull request fixes the following error: Html Logger Error : The process cannot access the file 'C:\xxxxxxx\TestResult_XXXXXXXXXX_20220215_084850.xml' because it is being used by another process., while running tests for multiple projects on the same solution.

[nohwnd]

Thanks for your contribution :)

@Haplois imho we had a code for this somewhere, could you remind me? Or were you doing that fix in testfx?

[ntovas]

@nohwnd in TrxFileHelper there is code that has the same functionality, I wanted to make something common and reusable, but I don't have any familiarity with the codebase.

[nohwnd]

@ntovas perfect. 👍

[defilerc]

@nohwnd Hi! Is there any chance you plan to merge this fix soon? The fix follows the same logic used in TrxFileHelper mentioned above by @ntovas .

[nohwnd]

Thanks for reminding me about this. Added to my work list for Tuesday.

[ntovas]

I reviewed my code and made some changes, please check them again @nohwnd :)

[Evangelink]

Looks like some of the acceptance tests are failing (probably because of the name change), tests are:

• HtmlLoggerWithExecutorUriShouldProperlyOverwriteFile
• HtmlLoggerWithFriendlyNameShouldProperlyOverwriteFile

[Evangelink]

Hey @ntovas, would you be willing to make the extra changes so we can move forward and get this PR merged? If not, please let us know so we can take it over from here.

Thank you for what you have done so far!

[ntovas]

Hello @Evangelink ,

Yes, I will try to make the changes, sorry but I missed the notifications about this.

[Evangelink]

No worries at all @ntovas. Thank you for taking care of this and feel free to ask any question.

[ntovas]

@Evangelink I have an issue running the unit tests locally, so I am not exactly sure why it's failing ¯_(ツ)_/¯

[Evangelink]

@ntovas I will look into it. Thanks for updating the PR :)

[Evangelink]

Unrelated change but there was no need for the string.Concat.

[Evangelink]

Thank you for the contribution @ntovas!