Test adapter loading strategy #3380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haplois
commented
Feb 16, 2022
src/Microsoft.TestPlatform.ObjectModel/TestAdapterLoadingStrategy.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TestPlatform.ObjectModel/TestAdapterLoadingStrategy.cs
Outdated
Show resolved
Hide resolved
src/vstest.console/Processors/TestAdapterLoadingStrategyArgumentProcessor.cs
Outdated
Show resolved
Hide resolved
Haplois
force-pushed
the
dev/haplois/test-adapter-loading-strategy
branch
from
bdeb9d9
to
b58979f
Compare
MarcoRossignoli
approved these changes
Feb 17, 2022
src/Microsoft.TestPlatform.Common/Utilities/RunSettingsUtilities.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TestPlatform.ObjectModel/RunSettings/RunConfiguration.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TestPlatform.ObjectModel/TestAdapterLoadingStrategy.cs
Outdated
Show resolved
Hide resolved
src/vstest.console/Processors/TestAdapterLoadingStrategyArgumentProcessor.cs
Outdated
Show resolved
Hide resolved
src/vstest.console/Processors/TestAdapterLoadingStrategyArgumentProcessor.cs
Outdated
Show resolved
Hide resolved
src/vstest.console/Processors/TestAdapterLoadingStrategyArgumentProcessor.cs
Show resolved
Hide resolved
Haplois
commented
Feb 17, 2022
Evangelink
reviewed
Feb 17, 2022
src/vstest.console/Processors/TestAdapterLoadingStrategyArgumentProcessor.cs
Outdated
Show resolved
Hide resolved
src/vstest.console/Processors/TestAdapterLoadingStrategyArgumentProcessor.cs
Outdated
Show resolved
Hide resolved
src/vstest.console/Processors/TestAdapterPathArgumentProcessor.cs
Outdated
Show resolved
Hide resolved
src/vstest.console/Processors/TestAdapterPathArgumentProcessor.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Marco Rossignoli <[email protected]>
nohwnd
reviewed
Feb 17, 2022
src/vstest.console/Processors/TestAdapterLoadingStrategyArgumentProcessor.cs
Outdated
Show resolved
Hide resolved
src/vstest.console/Processors/TestAdapterLoadingStrategyArgumentProcessor.cs
Outdated
Show resolved
Hide resolved
src/vstest.console/Processors/TestAdapterLoadingStrategyArgumentProcessor.cs
Outdated
Show resolved
Hide resolved
src/vstest.console/Processors/TestAdapterLoadingStrategyArgumentProcessor.cs
Show resolved
Hide resolved
src/vstest.console/Processors/TestAdapterPathArgumentProcessor.cs
Outdated
Show resolved
Hide resolved
Evangelink
reviewed
Feb 17, 2022
| @@ -91,15 +90,15 @@ public TestPlatform() | |||
| PopulateExtensions(discoveryCriteria.RunSettings, discoveryCriteria.Sources); | |||
|
|
|||
| // Initialize loggers. | |||
| var loggerManager = TestEngine.GetLoggerManager(requestData); | |||
| ITestLoggerManager loggerManager = TestEngine.GetLoggerManager(requestData); | |||
There was a problem hiding this comment.
If we all agree, I could change the var rules in the repo to favor explicit type when not obvious.
My opinion: I usually prefer var in VS but that's true that var in GitHub review is a bit of a pain.
There was a problem hiding this comment.
I love var, but wgen it's not obvious it hard do discern that while reviewing. I would vote for yes.
src/vstest.console/Processors/TestAdapterLoadingStrategyArgumentProcessor.cs
Outdated
Show resolved
Hide resolved
src/vstest.console/Processors/TestAdapterLoadingStrategyArgumentProcessor.cs
Outdated
Show resolved
Hide resolved
Evangelink
approved these changes
Feb 17, 2022
|
@Evangelink thanks for the review, I'll add the tests and ask for another review. |
nohwnd
approved these changes
Feb 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The code here is cherry-picked from our 17.1 release.
Work left
TestAdapterLoadingStrategyfrom.runsettingsfile.