Follow .NET lifecycle: update codebase to net462 #3646
Conversation
Evangelink
force-pushed
the
net45X-to-net462
branch
from
efab515
to
37809ee
Compare
Evangelink
changed the title
Evangelink
force-pushed
the
net45X-to-net462
branch
2 times, most recently
from
2bb119d
to
2f17d48
Compare
Evangelink
force-pushed
the
net45X-to-net462
branch
from
abcf88a
to
1a4b156
Compare
Evangelink
force-pushed
the
net45X-to-net462
branch
2 times, most recently
from
9615564
to
2c57707
Compare
Evangelink
force-pushed
the
net45X-to-net462
branch
from
2c57707
to
be41470
Compare
| @@ -13,7 +13,7 @@ | |||
| <AssemblyName Condition=" '$(RuntimeIdentifier)' == 'win10-arm64' ">datacollector.arm64</AssemblyName> | |||
| <TargetFrameworks>netcoreapp2.1</TargetFrameworks> | |||
| <TargetFrameworks Condition=" '$(OS)' == 'WINDOWS_NT' ">$(TargetFrameworks);net472</TargetFrameworks> | |||
There was a problem hiding this comment.
Why do we have a different min TFM depending on windows or not? I'd like to document that in the project.
There was a problem hiding this comment.
The windows code of datacollector is using something that is net472 specific, I don't remember what it is though, but you should be able to see if you downgrade. You can remove the condition for the different tfm on Linux, that probably happened because getting the whole thing build on linux was difficult in the past and I did not want to disrupt the linux build by changing it.
test/Microsoft.TestPlatform.AcceptanceTests/AcceptanceTestBase.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.TestPlatform.AcceptanceTests/CodeCoverageAcceptanceTestBase.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.TestPlatform.AcceptanceTests/DeprecateExtensionsPathWarningTests.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.TestPlatform.AcceptanceTests/TranslationLayerTests/CustomTestHostTests.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.TestPlatform.AcceptanceTests/TranslationLayerTests/CustomTestHostTests.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.TestPlatform.AcceptanceTests/TranslationLayerTests/RunTests.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.TestPlatform.AcceptanceTests/TranslationLayerTests/RunTests.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.TestPlatform.AdapterUtilities.UnitTests/ManagedNameUtilities/SpecialNameTests.cs
Show resolved
Hide resolved
test/Microsoft.TestPlatform.Common.PlatformTests/AssemblyPropertiesTests.cs
Show resolved
Hide resolved
test/Microsoft.TestPlatform.Common.PlatformTests/AssemblyPropertiesTests.cs
Show resolved
Hide resolved
test/Microsoft.TestPlatform.ObjectModel.PlatformTests/DiaSessionTests.cs
Show resolved
Hide resolved
test/Microsoft.TestPlatform.AcceptanceTests/TranslationLayerTests/RunTests.cs
Outdated
Show resolved
Hide resolved
You mean for TargetFrameworks in the csproj? I thought we have the defaults in Directory.Build.props, maybe I am wrong. But that is probably the best place for a baseline. |
Yes. Just so that it's easier to update. |
Evangelink
force-pushed
the
net45X-to-net462
branch
from
97200f5
to
270adfd
Compare
src/Microsoft.TestPlatform.CoreUtilities/PublicAPI/net451/PublicAPI.Shipped.txt
Show resolved
Hide resolved
| @@ -19,7 +19,7 @@ public class TraitCollection : IEnumerable<Trait> | |||
| internal const string TraitPropertyId = "TestObject.Traits"; | |||
| private static readonly TestProperty TraitsProperty = TestProperty.Register( | |||
| TraitPropertyId, | |||
| #if !NET451 | |||
| #if !NET462 | |||
There was a problem hiding this comment.
this seems wrong. the condition said if not net451 before, so for net462 the condition body should be used, and else case should be removed.
There was a problem hiding this comment.
Will do in a follow-up PR.
Description
Follow Microsoft .NET Framework component lifecycle policy by dropping support for .NET Framework older than 4.6.2.
Related issue
Replaces #3517 and fixes AB#1491257