Enable nullable for EventLogCollector #3674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
commented
May 24, 2022
| DataCollectionEvents events!!, | ||
| DataCollectionSink dataSink!!, | ||
| DataCollectionLogger logger!!, | ||
| DataCollectionEnvironmentContext dataCollectionEnvironmentContext) | ||
| DataCollectionEnvironmentContext dataCollectionEnvironmentContext!!) |
There was a problem hiding this comment.
This is a change of behavior but we weren't doing null check so if Initialize is called with null for this arg we would fail with NRE.
| public override void Initialize( | ||
| XmlElement configurationElement, | ||
| XmlElement? configurationElement, |
There was a problem hiding this comment.
Functionally we should accept only non-null but that would be a change of behavior so I decided to allow null.
| @@ -267,6 +266,7 @@ internal string WriteEventLogs(List<EventLogEntry> eventLogEntries, int maxLogEn | |||
| // Write the event log file | |||
| FileTransferInformation fileTransferInformation = | |||
| new(dataCollectionContext, eventLogPath, true, _fileHelper); | |||
| TPDebug.Assert(_dataSink != null, "Initialize should have been called."); | |||
There was a problem hiding this comment.
We cannot use the initialize pattern we were talking about because this method is called from within the Initialize method.
MarcoRossignoli
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to AB#1549371