Enable nullable on TP utilities #3700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
commented
Jun 1, 2022
| @@ -584,7 +584,7 @@ private static void ValidateRunConfiguration(XPathNavigator runSettingsNavigator | |||
| XmlUtilities.AppendOrModifyChild(xmlDocument, TargetFrameworkNodePath, TargetFrameworkNodeName, effectiveFramework.ToString()); | |||
| } | |||
|
|
|||
| public static bool TryGetPlatformXml(XPathNavigator runSettingsNavigator, out string platformXml) | |||
| public static bool TryGetPlatformXml(XPathNavigator runSettingsNavigator, out string? platformXml) | |||
There was a problem hiding this comment.
If platform is null we return true, that seems weird to me. Usually in TryXXX methods you return true when you have something valid.
Evangelink
force-pushed
the
tp-utilities-nullable
branch
from
2f4327c
to
027377b
Compare
nohwnd
approved these changes
Jun 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to AB#1549371