Add default platform option to runsettings #3770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
reviewed
Jun 16, 2022
src/Microsoft.TestPlatform.ObjectModel/RunSettings/RunConfiguration.cs
Outdated
Show resolved
Hide resolved
test/vstest.console.UnitTests/TestPlatformHelpers/TestRequestManagerTests.cs
Show resolved
Hide resolved
Evangelink
approved these changes
Jun 16, 2022
…rojects because of net451.
MarcoRossignoli
approved these changes
Jun 16, 2022
This was referenced Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add default platform option that determines the platform to use for AnyCPU sources, without forcing it at sources that are built for specific platform.
This is equivalent of this dropdown in VS:
Not setting DefaultPlatform is equivalent to the
Autooption. Which is fallback to the platform of the current process. E.g. x64 for x64 VisualStudio, or arm64 for arm64 VisualStudio.The difference between TargetPlatform and DefaultPlatform, is that TargetPlatform will force the platform on all sources, and the ones that don't match will be skipped or will fail with error.