Add background option for testhosts #3772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nohwnd
reviewed
Jun 16, 2022
nohwnd
reviewed
Jun 16, 2022
src/Microsoft.TestPlatform.TestHostProvider/Hosting/DefaultTestHostManager.cs
Outdated
Show resolved
Hide resolved
nohwnd
reviewed
Jun 16, 2022
Evangelink
force-pushed
the
background-option
branch
from
1925476
to
8c56ce9
Compare
nohwnd
approved these changes
Jun 17, 2022
| testHostPriority = environmentVariableHelper.GetEnvironmentVariableAsEnum("VSTEST_HOST_INTERNAL_PRIORITY", testHostPriority); | ||
| testHostProcess.PriorityClass = testHostPriority; | ||
| EqtTrace.Verbose("Setting test host process priority to {0}", testHostProcess.PriorityClass); | ||
| if (testHostEnvironmentVariables is not null |
There was a problem hiding this comment.
@Evangelink @nohwnd I am not familiar with the code base - but is DefaultTestHostManager also used when parallel is not in play?
Just want to make sure that it is possible to create low prio test hosts -
a) regardless of whether parallel is turned on and
b) regardless of whether the operation requested is execution versus discovery
Also if the answer to b) above is yes, then it may be better to rename this to something more general like VSTEST_BACKGROUND_OPERATION or VSTEST_BACKGROUND_PRIORITY :)
There was a problem hiding this comment.
Yes that code is used even in "sequential". This is used to decide on the level of parallelism (including sequential) to use.
This was referenced Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes AB#1555397