Remove unused msdia140typelib_clr0200.dll #3822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes looks good, are we waiting for something to merge it? |
|
yeah...I'm doing some manual tests |
Evangelink
approved these changes
Jun 29, 2022
This was referenced Jul 21, 2022
akoeplinger
added a commit
to dotnet/sdk
that referenced
this pull request
Mar 7, 2024
The msdia140typelib_clr0200.dll was removed from vstest in microsoft/vstest#3822
akoeplinger
added a commit
to dotnet/sdk
that referenced
this pull request
Mar 8, 2024
…ets (#39304) The msdia140typelib_clr0200.dll was removed from vstest in microsoft/vstest#3822 This actually never worked in the Microsoft build (because we're building the SDK layout on Windows) and we shipped the binary in the non-Windows SDKs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like we already moved away from msdia managed wrapper in favor of pinvoke to
msdia140.dllhttps://github.com/microsoft/vstest/pull/1018/files#diff-1ce965d15e48a18ef21ff22c84fd034f046ddc15aebea432babfa403cff86473Remove ref to
Microsoft.Internal.Dia.Interopthat containsmsdia140typelib_clr0200.dll