Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Microsoft.NET.Test.Sdk package transitive #3879

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

Evangelink
Copy link
Member

Fixes #3227

I have tested locally with the project linked in the issue that wasn't working before and is now working.

I have also checked that the testhost and other relevant files are correctly copied to the output.

Hopefully there is no unanticipated bad behaviour.

Copy link
Contributor

@Haplois Haplois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check compatibility with 16.11 version of VS too.

@Evangelink
Copy link
Member Author

It works well
image

@Haplois Haplois merged commit 166cf16 into microsoft:main Jul 21, 2022
@Evangelink Evangelink deleted the test-sdk-transitive branch July 22, 2022 09:25
@jonpryor
Copy link
Member

This change causes #4098; for certain projects, it means that simply updating the Microsoft.NET.Test.Sdk can cause the project to stop building.

Those "certain projects" are projects which provide their own Main() method and reference Microsoft.NET.Test.Sdk indirectly via transitive dependencies.

Should this be considered a "breaking" change, insofar as updating the Microsoft.NET.Test.Sdk package can cause build failures?

What is the best way to resolve this? Document this change somewhere? (NuGet.org doesn't have a link for "release notes", so I'm not sure how anyone would find any such documentation, but it's a least a plausible answer?)

Make inclusion of e.g. Microsoft.NET.Test.Sdk.Program.cs conditional on '$(OutputType)' != 'Exe'?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Microsoft.NET.Test.Sdk package is not transitive (request for moving content from build to buildTransitive)
3 participants