Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable arm64 ngen #3931

Merged
merged 2 commits into from
Aug 17, 2022
Merged

Conversation

MarcoRossignoli
Copy link
Contributor

@MarcoRossignoli MarcoRossignoli commented Aug 9, 2022

Re-enable arm64 ngen

@MarcoRossignoli MarcoRossignoli marked this pull request as ready for review August 17, 2022 13:57
@MarcoRossignoli MarcoRossignoli enabled auto-merge (squash) August 17, 2022 13:57
@MarcoRossignoli
Copy link
Contributor Author

@ankitvarmait I'm re-enabling arm64 ngen for test host using the preview, now manifest looks good for arm64 modules:
image

@davkean pls let us know if you see something strange inside logs.
@ankitvarmait some ETA for the rtm release?

@MarcoRossignoli MarcoRossignoli merged commit e0ae648 into microsoft:main Aug 17, 2022
@MarcoRossignoli MarcoRossignoli deleted the enablearm64ngen branch August 17, 2022 14:24
<VsixSourceItem Update="$(VsixInputFileLocation)\testhost.net47.arm64.exe" Ngen="true" NgenArchitecture="Arm64" NgenPriority="2" NgenApplication="$(ExtensionInstallationRelativeToVS)\testhost.net47.arm64.exe" />
<VsixSourceItem Update="$(VsixInputFileLocation)\testhost.net471.arm64.exe" Ngen="true" NgenArchitecture="Arm64" NgenPriority="2" NgenApplication="$(ExtensionInstallationRelativeToVS)\testhost.net471.arm64.exe" />
<VsixSourceItem Update="$(VsixInputFileLocation)\testhost.net472.arm64.exe" Ngen="true" NgenArchitecture="Arm64" NgenPriority="2" NgenApplication="$(ExtensionInstallationRelativeToVS)\testhost.net472.arm64.exe" />
<VsixSourceItem Update="$(VsixInputFileLocation)\testhost.net48.arm64.exe" Ngen="true" NgenArchitecture="Arm64" NgenPriority="2" NgenApplication="$(ExtensionInstallationRelativeToVS)\testhost.net48.arm64.exe" />
Copy link
Member

@davkean davkean Aug 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a matter of interest why do you have architecture + target framework versions of your test host?

I would consider targeting the lowest version and then setting the https://docs.microsoft.com/en-us/dotnet/api/system.appdomainsetup.targetframeworkname?view=net-6.0 property when setting up the AppDomain to the user's target to enable quirks for those tests.

Copy link
Contributor Author

@MarcoRossignoli MarcoRossignoli Aug 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose historical reason(on how the host is located today) but maybe @nohwnd has got better reason.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reason is that I did not know you can do it this way when I added the additional testhosts, and no-one suggested it before we do it this way.

MarcoRossignoli pushed a commit to MarcoRossignoli/vstest that referenced this pull request Aug 19, 2022
nohwnd pushed a commit to nohwnd/vstest that referenced this pull request Aug 19, 2022
MarcoRossignoli pushed a commit to MarcoRossignoli/vstest that referenced this pull request Aug 19, 2022
MarcoRossignoli pushed a commit to MarcoRossignoli/vstest that referenced this pull request Oct 13, 2022
MarcoRossignoli added a commit that referenced this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants