Add support for ppc64le processor architecture #4028

Sapana-Khemkar · 2022-09-27T08:22:35Z

Description

We have added support for the ppc64le processor architecture to the dotnet runtime. For that we have added a new value for the System.Runtime.InteropServices.Architecture enum: dotnet/runtime#67428
Code in Microsoft.VisualStudio.TestPlatform.PlatformAbstractions does not recognize this new value. This patch adds a new value to Microsoft.VisualStudio.TestPlatform.PlatformAbstractions.PlatformArchitecture.

Related issue

NA

Sapana-Khemkar · 2022-09-27T09:28:14Z

@microsoft-github-policy-service agree [company="{IBM}"] From: microsoft-github-policy-service[bot] ***@***.***> Sent: Tuesday, September 27, 2022 1:53 PM To: microsoft/vstest ***@***.***> Cc: Sapana Khemkar ***@***.***>; Mention ***@***.***> Subject: [EXTERNAL] Re: [microsoft/vstest] Add support for ppc64le processor architecture (PR #4028) @Sapana-Khemkar please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information. @microsoft-github-policy-service agree [company="{your company}"] Options: ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ‍ ZjQcmQRYFpfptBannerStart This Message Is From an External Sender This message came from outside your organization. ZjQcmQRYFpfptBannerEnd @Sapana-Khemkar<https://github.com/Sapana-Khemkar> please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information. @microsoft-github-policy-service agree [company="{your company}"] Options: * (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer. * (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer. Contributor License Agreement Contribution License Agreement This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”), and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your contributions to Microsoft open source projects. This Agreement is effective as of the latest signature date below. 1. Definitions. “Code” means the computer software code, whether in human-readable or machine-executable form, that is delivered by You to Microsoft under this Agreement. “Project” means any of the projects owned or managed by Microsoft and offered under a license approved by the Open Source Initiative (www.opensource.org<http://www.opensource.org>). “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any Project, including but not limited to communication on electronic mailing lists, source code control systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of discussing and improving that Project, but excluding communication that is conspicuously marked or otherwise designated in writing by You as “Not a Submission.” “Submission” means the Code and any other copyrightable material Submitted by You, including any associated comments and documentation. 2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any Project. This Agreement covers any and all Submissions that You, now or in the future (except as described in Section 4 below), Submit to any Project. 3. Originality of Work. You represent that each of Your Submissions is entirely Your original work. Should You wish to Submit materials that are not Your original work, You may Submit them separately to the Project if You (a) retain all copyright and license information that was in the materials as You received them, (b) in the description accompanying Your Submission, include the phrase “Submission containing materials of a third party:” followed by the names of the third party and any licenses or other restrictions of which You are aware, and (c) follow any other instructions in the Project’s written guidelines concerning Submissions. 4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your Submission is made in the course of Your work for an employer or Your employer has intellectual property rights in Your Submission by contract or applicable law, You must secure permission from Your employer to make the Submission before signing this Agreement. In that case, the term “You” in this Agreement will refer to You and the employer collectively. If You change employers in the future and desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement and secure permission from the new employer before Submitting those Submissions. 5. Licenses. * Copyright License. You grant Microsoft, and those who receive the Submission directly or indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third parties. * Patent License. You grant Microsoft, and those who receive the Submission directly or indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under Your patent claims that are necessarily infringed by the Submission or the combination of the Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and import or otherwise dispose of the Submission alone or with the Project. * Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement. No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are granted by implication, exhaustion, estoppel or otherwise. 1. Representations and Warranties. You represent that You are legally entitled to grant the above licenses. You represent that each of Your Submissions is entirely Your original work (except as You may have disclosed under Section 3). You represent that You have secured permission from Your employer to make the Submission in cases where Your Submission is made in the course of Your work for Your employer or Your employer has intellectual property rights in Your Submission by contract or applicable law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You have the necessary authority to bind the listed employer to the obligations contained in this Agreement. You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE. 2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which You later become aware that would make Your representations in this Agreement inaccurate in any respect. 3. Information about Submissions. You agree that contributions to Projects and information about contributions may be maintained indefinitely and disclosed publicly, including Your name and other information that You submit with Your Submission. 4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County, Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all defenses of lack of personal jurisdiction and forum non-conveniens. 5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and supersedes any and all prior agreements, understandings or communications, written or oral, between the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft. — Reply to this email directly, view it on GitHub<#4028 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWNRWBDNPUV7SO3P3UFUSGLWAKVF3ANCNFSM6AAAAAAQWQ77GE>. You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>

omajid · 2022-09-27T12:44:35Z

src/Microsoft.TestPlatform.PlatformAbstractions/Interfaces/System/PlatformArchitecture.cs

@@ -13,4 +13,5 @@ public enum PlatformArchitecture
    ARM,
    ARM64,
    S390x,
+    PPC64le,


Maybe name this Ppc64le to keep it consistent with dotnet/runtime?

Agree. Will change

omajid · 2022-09-27T12:44:37Z

src/Microsoft.TestPlatform.PlatformAbstractions/netcore/System/PlatformEnvironment.cs

@@ -28,6 +28,7 @@ public PlatformArchitecture Architecture
                // preview 6 or later, so use the numerical value for now.
                // case System.Runtime.InteropServices.Architecture.S390x:
                (Architecture)5 => PlatformArchitecture.S390x,
+                (Architecture)6 => PlatformArchitecture.PPC64le,


Is this value correct? Shouldn't this be 8? I am looking at https://github.com/dotnet/runtime/blob/main/src/libraries/System.Private.CoreLib/src/System/Runtime/InteropServices/Architecture.cs, and there's LoongArch64 and Armv6 between S390x and PPC64le.

yes you are right. Thanks for catching that. I matched it with enum in VSTest code so counted it 6. Will correct.

….InteropServices.Architecture enum name

…stractions.PlatformArchitecture.Ppc64le and Microsoft.VisualStudio.TestPlatform.ObjectModel.Architecture.Ppc64le in Microsoft.TestPlatform.ObjectModel and /Microsoft.TestPlatform.PlatformAbstractions PublicAPI.Shipped.txt file.

leecow · 2022-09-28T20:50:44Z

@nohwnd - could you have a look so that we can queue this up for .NET 7 GA review?

cc @crummel

Sapana-Khemkar · 2022-09-30T07:31:35Z

@nohwnd Thanks for merging. Where can I find daily build artifacts for VSTest repo? Azure Link provided in readme is not reachable. Can you please help?

nohwnd · 2022-09-30T10:47:02Z

@Sapana-Khemkar there is some issue with our token for publishing into our public feed, we are trying to fix it so you can see the preview package that would go into net8 and possibly try it.

Sapana-Khemkar · 2022-09-30T13:11:42Z

@Sapana-Khemkar there is some issue with our token for publishing into our public feed, we are trying to fix it so you can see the preview package that would go into net8 and possibly try it.

Noted. Thanks.

Sapana-Khemkar · 2022-10-04T13:25:30Z

@nohwnd It seems Azure link is yet not up. Is there anyway to download daily build binary for testing?

janani66 · 2022-10-05T20:14:41Z

@nohwnd - Where can we download the preview package that would go into net8? Just trying to access a binary build with the fix for #4028 for testing purposes.

nohwnd · 2022-10-07T07:44:37Z

@Sapana-Khemkar @janani66 Just using the latest dotnet installer for net8-alpha should be the easiest way to acquire it. The latest successful merge from vstest to dotnet/sdk happened 3 days ago, and from sdk to installer 2 days ago. So it should be safely there. But please double check the version printed in the console when you use dotnet test, the number is a date, you want October 1st or newer.

As for the nuget package we insert into dotnet/sdk that one is here: https://dev.azure.com/dnceng/public/_artifacts/feed/test-tools/NuGet/Microsoft.TestPlatform.CLI/overview/17.5.0-preview-20221007-01

If you want redistributable .NET Framework package you should choose Microsoft.TestPlatform (without the .CLI) instead. That is what CI servers use to run tests, when not using dotnet test.

This is the feed we push it into: https://dev.azure.com/dnceng/public/_artifacts/feed/test-tools

nohwnd · 2022-10-07T07:46:00Z

@janani66 Or maybe you want Microsoft.NET.Test.SDK which is what you install in your .NET project, that package is here https://dev.azure.com/dnceng/public/_artifacts/feed/test-tools/NuGet/Microsoft.NET.Test.Sdk/overview/17.5.0-preview-20221007-01 on the same feed.

janani66 · 2022-10-11T15:01:06Z

@nohwnd The test with the 17.5.0-preview-20221007-01 failed to recognize ppc64le as a supportedArchitecture. Has something changed In .NET7 w.r.t. VSTest integration with .NET .

ubuntu@dotnet1:~/janani$ dotnet --info
.NET SDK:
Version: 7.0.100-preview.7.22377.5
Commit: ba310d9309

Runtime Environment:
OS Name: ubuntu
OS Version: 20.04
OS Platform: Linux
RID: linux-ppc64le
Base Path: /home/ubuntu/sapana/preview7/output/.dotnet/sdk/7.0.100-preview.7.22377.5/

Host:
Version: 7.0.0-preview.7.22375.6
Architecture: ppc64le
Commit: N/A

.NET SDKs installed:
7.0.100-preview.7.22377.5 [/home/ubuntu/sapana/preview7/output/.dotnet/sdk]

.NET runtimes installed:
Microsoft.AspNetCore.App 7.0.0-preview.7.22376.6 [/home/ubuntu/sapana/preview7/output/.dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.NETCore.App 7.0.0-preview.7.22375.6 [/home/ubuntu/sapana/preview7/output/.dotnet/shared/Microsoft.NETCore.App]

Other architectures found:
None

Environment variables:
DOTNET_ROOT [/home/ubuntu/sapana/preview7/output/.dotnet]

global.json file:
Not found

To Reproduce the Problem

Create a sample xunit program
dotnet new xunit
Modify the csproj to override the Microsoft.NET.Test.Sdk page

<Project Sdk="Microsoft.NET.Sdk">
  
  <PropertyGroup>
    <TargetFramework>net7.0</TargetFramework>
    <ImplicitUsings>enable</ImplicitUsings>
    <Nullable>enable</Nullable>

    <IsPackable>false</IsPackable>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.5.0-preview-20221007-01" />
    <PackageReference Include="xunit" Version="2.4.1" />
    <PackageReference Include="xunit.runner.visualstudio" Version="2.4.3">
      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
      <PrivateAssets>all</PrivateAssets>
    </PackageReference>
    <PackageReference Include="coverlet.collector" Version="3.1.2">
      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
      <PrivateAssets>all</PrivateAssets>
    </PackageReference>
  </ItemGroup>

</Project>

Run the program
dotnet test

This gives error:
$ dotnet test
Determining projects to restore...
All projects are up-to-date for restore.
/home/ubuntu/sapana/preview7/output/.dotnet/sdk/7.0.100-preview.7.22377.5/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.RuntimeIdentifierInference.targets(219,5): message NETSDK1057: You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy [/home/ubuntu/janani/vstest/janani.csproj]
janani -> /home/ubuntu/janani/vstest/bin/Debug/net7.0/janani.dll
Test run for /home/ubuntu/janani/vstest/bin/Debug/net7.0/janani.dll (.NETCoreApp,Version=v7.0)

Unhandled Exception:
System.NotSupportedException: Specified method is not supported.
at Microsoft.VisualStudio.TestPlatform.PlatformAbstractions.ProcessHelper.GetCurrentProcessArchitecture()
at Microsoft.VisualStudio.TestPlatform.CommandLine.Executor.PrintSplashScreen(Boolean isDiag)
at Microsoft.VisualStudio.TestPlatform.CommandLine.Executor.Execute(String[] args)
at Microsoft.VisualStudio.TestPlatform.CommandLine.Program.Run(String[] args, UiLanguageOverride uiLanguageOverride)
at Microsoft.VisualStudio.TestPlatform.CommandLine.Program.Main(String[] args)
[ERROR] FATAL UNHANDLED EXCEPTION: System.NotSupportedException: Specified method is not supported.
at Microsoft.VisualStudio.TestPlatform.PlatformAbstractions.ProcessHelper.GetCurrentProcessArchitecture()
at Microsoft.VisualStudio.TestPlatform.CommandLine.Executor.PrintSplashScreen(Boolean isDiag)
at Microsoft.VisualStudio.TestPlatform.CommandLine.Executor.Execute(String[] args)
at Microsoft.VisualStudio.TestPlatform.CommandLine.Program.Run(String[] args, UiLanguageOverride uiLanguageOverride)
at Microsoft.VisualStudio.TestPlatform.CommandLine.Program.Main(String[] args)

janani66 · 2022-10-11T15:26:40Z

Running the code on ppc64le I get:

using System.Runtime.InteropServices;

foreach (var name in Enum.GetNames())
{
Architecture value = Enum.Parse(name);
Console.WriteLine($"{name} is {value.ToString("D")}");
}

Console.WriteLine($"OS Arch: {RuntimeInformation.OSArchitecture}");
Console.WriteLine($"Processor Arch: {RuntimeInformation.ProcessArchitecture}");

gives me:

$ dotnet run
X86 is 0
X64 is 1
Arm is 2
Arm64 is 3
Wasm is 4
S390x is 5
LoongArch64 is 6
Armv6 is 7
Ppc64le is 8
OS Arch: Ppc64le
Processor Arch: Ppc64le

MarcoRossignoli · 2022-10-12T06:56:27Z

@janani66 the new enum won't be shipped into 7.0(we're in stabilization feature phase) you should try with the preview SDK 8.0 that you download from here https://github.com/dotnet/installer#table

janani66 · 2022-10-12T13:41:08Z

Looks like we also need the fix : #4066

janani66 · 2022-10-24T13:25:18Z

I was able to test with the 17.5.0-preview-20221024-01 build published on https://pkgs.dev.azure.com/dnceng/public/_packaging/test-tools/nuget/v3/index.json. and the dotnet xunit test passed.

A couple of comments/questions:

If I add a nuget.config file like shown at: https://dev.azure.com/dnceng/public/_artifacts/feed/test-tools/connect/nuget.exe

it is not able to find "Newtonsoft.Json": "13.0.1".

Once I remove the "clear" from the nuget.config, it found NewtonSoft.Json from nuget.org. Is there a reason why the example nuget.config on the dnceng feed shows the clear in the example nuget.config?

i.e.

<?xml version="1.0" encoding="utf-8"?>
<configuration>
  <packageSources>
    <clear />
    <add key="test-tools" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/test-tools/nuget/v3/index.json" />
  </packageSources>
</configuration>

Just wanted to point out that on this page https://dev.azure.com/dnceng/public/_artifacts/feed/test-tools/connect/dotnet, the {0}/{1}/{2} variables are not substituted for nuget.config {0}/.csproj{1}/.sln{{2}

MarcoRossignoli · 2022-11-02T12:34:00Z

Is there a reason why the example nuget.config on the dnceng feed shows the clear in the example nuget.config?

Because our test-tools feed doesn't have any upstream and so there you can find only packages released by us and not for instance Newtonsoft.Json": "13.0.1

Just wanted to point out that on this page https://dev.azure.com/dnceng/public/_artifacts/feed/test-tools/connect/dotnet, the {0}/{1}/{2} variables are not substituted for nuget.config {0}/.csproj{1}/.sln{{2}

this is not clear to me...can you elaborate? I don't see any {0}/{1}/{2} in that page.

janani66 · 2022-11-02T13:20:40Z

Just wanted to point out that on this page https://dev.azure.com/dnceng/public/_artifacts/feed/test-tools/connect/dotnet, the {0}/{1}/{2} variables are not substituted for nuget.config {0}/.csproj{1}/.sln{{2}

this is not clear to me...can you elaborate? I don't see any {0}/{1}/{2} in that page.

On the https://dev.azure.com/dnceng/public/_artifacts/feed/test-tools/connect/dotnet page, I see under "Project setup"

Add a {0} file to your project, in the same folder as your {1} or {2} file

add support for ppc64le processor architecture

96591cb

microsoft-github-policy-service bot deleted a comment Sep 27, 2022

Sapana-Khemkar marked this pull request as ready for review September 27, 2022 09:29

omajid reviewed Sep 27, 2022

View reviewed changes

Sapana-Khemkar added 2 commits September 28, 2022 13:30

change enum name from PPC64le to Ppc64le to match with System.Runtime…

750b193

….InteropServices.Architecture enum name

Sapana-Khemkar requested review from nohwnd and MarcoRossignoli as code owners September 28, 2022 12:31

corrected typo in ppc64le arch name

389b923

omajid mentioned this pull request Sep 29, 2022

vstest has a hardcoded list of architectures which makes porting to new architectures harder #4034

Closed

nohwnd approved these changes Sep 30, 2022

View reviewed changes

nohwnd merged commit 255e975 into microsoft:main Sep 30, 2022

nohwnd pushed a commit to nohwnd/vstest that referenced this pull request Sep 30, 2022

Add support for ppc64le processor architecture (microsoft#4028)

6fe9d51

nohwnd mentioned this pull request Sep 30, 2022

[rel/17.4] Add support for ppc64le processor architecture #4035

Closed

Sapana-Khemkar mentioned this pull request Oct 19, 2022

[rel/17.4] Fix Invalid target architecture 'S390x' error #4079

Merged

nohwnd pushed a commit to nohwnd/vstest that referenced this pull request Oct 19, 2022

Add support for ppc64le processor architecture (microsoft#4028)

cb1b799

Sapana-Khemkar mentioned this pull request Jan 13, 2023

change Microsoft.NET.Test.Sdk version from 17.3.2 to 17.4.0 dotnet/test-templates#278

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for ppc64le processor architecture #4028

Add support for ppc64le processor architecture #4028

Sapana-Khemkar commented Sep 27, 2022

Sapana-Khemkar commented Sep 27, 2022 via email

omajid Sep 27, 2022

Sapana-Khemkar Sep 28, 2022

omajid Sep 27, 2022

Sapana-Khemkar Sep 28, 2022

leecow commented Sep 28, 2022

Sapana-Khemkar commented Sep 30, 2022

nohwnd commented Sep 30, 2022

Sapana-Khemkar commented Sep 30, 2022

Sapana-Khemkar commented Oct 4, 2022

janani66 commented Oct 5, 2022

nohwnd commented Oct 7, 2022

nohwnd commented Oct 7, 2022

janani66 commented Oct 11, 2022 •

edited

Loading

janani66 commented Oct 11, 2022 •

edited

Loading

MarcoRossignoli commented Oct 12, 2022 •

edited

Loading

janani66 commented Oct 12, 2022

janani66 commented Oct 24, 2022 •

edited

Loading

MarcoRossignoli commented Nov 2, 2022

janani66 commented Nov 2, 2022 •

edited

Loading

Add support for ppc64le processor architecture #4028

Add support for ppc64le processor architecture #4028

Conversation

Sapana-Khemkar commented Sep 27, 2022

Description

Related issue

Sapana-Khemkar commented Sep 27, 2022 via email

omajid Sep 27, 2022

Choose a reason for hiding this comment

Sapana-Khemkar Sep 28, 2022

Choose a reason for hiding this comment

omajid Sep 27, 2022

Choose a reason for hiding this comment

Sapana-Khemkar Sep 28, 2022

Choose a reason for hiding this comment

leecow commented Sep 28, 2022

Sapana-Khemkar commented Sep 30, 2022

nohwnd commented Sep 30, 2022

Sapana-Khemkar commented Sep 30, 2022

Sapana-Khemkar commented Oct 4, 2022

janani66 commented Oct 5, 2022

nohwnd commented Oct 7, 2022

nohwnd commented Oct 7, 2022

janani66 commented Oct 11, 2022 • edited Loading

janani66 commented Oct 11, 2022 • edited Loading

MarcoRossignoli commented Oct 12, 2022 • edited Loading

janani66 commented Oct 12, 2022

janani66 commented Oct 24, 2022 • edited Loading

MarcoRossignoli commented Nov 2, 2022

janani66 commented Nov 2, 2022 • edited Loading

janani66 commented Oct 11, 2022 •

edited

Loading

janani66 commented Oct 11, 2022 •

edited

Loading

MarcoRossignoli commented Oct 12, 2022 •

edited

Loading

janani66 commented Oct 24, 2022 •

edited

Loading

janani66 commented Nov 2, 2022 •

edited

Loading