Fixed CC for in-process console scenarios #4084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
reviewed
Oct 24, 2022
...tPlatform.Client/AttachmentsProcessing/InProcessTestRunAttachmentsProcessingEventsHandler.cs
Outdated
Show resolved
Hide resolved
...tPlatform.Client/AttachmentsProcessing/InProcessTestRunAttachmentsProcessingEventsHandler.cs
Outdated
Show resolved
Hide resolved
Evangelink
changed the title
Yes, there's an internal ticket that we can link the PR to, will send it to you offline (and also link the PR). I agree with the last two test cases, I will write tests for them right away. The first test case though (case where the token is cancelled) is not feasible here, since the token is passed down to the |
Evangelink
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In-process vstest.console wrapper didn't implement CC attachment processing methods until now. These methods were implemented based on their counterparts in the out-of-process vstest.console wrapper, as well as by using important bits-and-pieces from the translation layer (which is no longer required since in-proc console removes the need of a translation layer).