Fix recursive resource lookup #4095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
reviewed
Oct 27, 2022
|
Pushed, not sure if it will work, I was able to test that it fails locally, but I can't build because of some problems around manifest. So let's try to see if CI will pass. |
|
@Evangelink works, approve? |
Evangelink
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check for recursive resource lookup.
This can happen when we are on non-english locale, and we try to load mscorlib.resources
(or potentially some other resources). This will trigger a new Resolve and call the method
we are currently in. If then some code in this Resolve method (like File.Exists) will again
try to access mscorlib.resources it will end up recursing forever.
So we check if the currently looked up assembly is a resource, and if it is we push it into stack
and then check the stack on additional resource lookup.
Related issue
AB#1654923