Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zoom.ZoomRooms version 5.15.7 #116892

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Zoom.ZoomRooms version 5.15.7 #116892

merged 3 commits into from
Oct 24, 2023

Conversation

BrandonWanHuanSheng
Copy link
Contributor

@BrandonWanHuanSheng BrandonWanHuanSheng commented Aug 15, 2023 •
edited by microsoft-github-policy-service bot
Loading

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the URL-Validation-Error Microsoft Defender SmartScreen triggered during automatic validation label Aug 15, 2023
@wingetbot
Copy link
Collaborator

Url validation error

@microsoft-github-policy-service
Copy link
Contributor

Hello @BrandonWanHuanSheng,

The package manager bot determined there was an issue with some of the URLs included in the manifest file. Please check the pull request for more details and make sure the urls are correct.

Template: msftbot/validationError/urls/smartScreen

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Aug 15, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed URL-Validation-Error Microsoft Defender SmartScreen triggered during automatic validation Needs-Author-Feedback This needs a response from the author. labels Aug 15, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @BrandonWanHuanSheng,

The package manager bot determined there was an issue with one of the installers listed in the url field, and cannot continue.

The application included in this pull request failed to install during dynamic validation. This test is designed to ensure that the application installs on all environments without warnings. Please, verify that the application installs correctly on architectures specified in the manifest using winget cli.

Template: msftbot/validationError/installers/shellExecute

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Aug 15, 2023
@BrandonWanHuanSheng
Copy link
Contributor Author

What is happening right over here?

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Aug 15, 2023
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Installation failed with exit code -1978335226
2023-08-15 06:12:18.682 [CLI ] ShellExecute installer failed: 1
image

@stephengillie
Copy link
Collaborator

Hi @BrandonWanHuanSheng,

Manual Validation also ended with the same error code: 1. When manually running the installer, it had many checkboxes checked that required a reboot:
image

So I'm wondering if the silent installer switches here might be leaving those checked, and that the non-zero error code might be due to the installer wanting to reboot but being unable to initiate one.

@stephengillie stephengillie added Needs-Author-Feedback This needs a response from the author. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Aug 15, 2023
@BrandonWanHuanSheng BrandonWanHuanSheng mentioned this pull request Aug 19, 2023
Closed
@BrandonWanHuanSheng BrandonWanHuanSheng removed their assignment Aug 19, 2023
@BrandonWanHuanSheng BrandonWanHuanSheng mentioned this pull request Sep 27, 2023
Closed
@BrandonWanHuanSheng
Copy link
Contributor Author

BrandonWanHuanSheng commented Oct 4, 2023 •
edited
Loading

Hi @BrandonWanHuanSheng,

Manual Validation also ended with the same error code: 1. When manually running the installer, it had many checkboxes checked that required a reboot:
image

So I'm wondering if the silent installer switches here might be leaving those checked, and that the non-zero error code might be due to the installer wanting to reboot but being unable to initiate one.

Actually, it look like some of Zoom Room exe silent switch can‘t be found. But only MSI support reboot. I try some basics commands with that setup. ZoomRooms.exe /Silent /Restart. But it didn't intalize restart. It look like it need to manually restart.

@Trenly
Copy link
Contributor

Trenly commented Oct 23, 2023

Stale PR; Please update or close
[Policy] Needs-Author-Feedback

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Oct 23, 2023
@BrandonWanHuanSheng
Copy link
Contributor Author

It looks like exe having a problem with the silent issue.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Oct 24, 2023
@BrandonWanHuanSheng
Copy link
Contributor Author

How to I set the InstallerExpectedCode: 1 Does it affects msi?

@BrandonWanHuanSheng
Copy link
Contributor Author

If I remove exe, the previous version of exe will not be able to upgrade Zoom.Rooms

@BrandonWanHuanSheng
Copy link
Contributor Author

This zoom room changed the interface.

@stephengillie stephengillie removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Oct 24, 2023
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Oct 24, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Oct 24, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit afd9961 into microsoft:master Oct 24, 2023
7 checks passed
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@microsoft-github-policy-service Microsoft GitHub Policy Service microsoft-github-policy-service approved these changes

@stephengillie stephengillie stephengillie approved these changes

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@BrandonWanHuanSheng @wingetbot @stephengillie @Trenly @hackean-msft @yao-msft