Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: TaskPlays.TSWModManager version 2.2.1 #118844

Merged
merged 4 commits into from
Sep 6, 2023
Merged

New package: TaskPlays.TSWModManager version 2.2.1 #118844

merged 4 commits into from
Sep 6, 2023

Conversation

aaronliu0130
Copy link
Contributor

@aaronliu0130 aaronliu0130 commented Sep 3, 2023 •
edited by microsoft-github-policy-service bot
Loading

Pull request has been created with Komac v1.11.0 🚀

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aaronliu0130
Copy link
Contributor Author

uhh what is happening

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Sep 3, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @aaronliu0130,

During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches?

This can also happen when a dependency is missing. You can test with https://github.com/microsoft/winget-pkgs#test-your-manifest.

Please investigate a fix and resubmit the Pull Request.

You may also try using the Windows Package Manager Manifest Creator to determine the proper installer type. If the installer type is MSIX, MSI, or a known installer technology like NullSoft, Inno, etc. the wingetcreate tool can detect them and the winget client will know what switches to pass. If it's a .exe installer of an unknown type, you will need to search to determine the proper switches for Silent and SilentWithProgress.

Template: msftbot/validationError/installation/unattended

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Sep 3, 2023
@aaronliu0130
Copy link
Contributor Author

Weird, even without switches the thing just installs without needing user input, it automatically goes into the progress bar. I'll search up some switches.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Sep 3, 2023
@stephengillie
Copy link
Collaborator

Hi @aaronliu0130,

Automatic Validation ended with:
image

@stephengillie stephengillie added Needs-Author-Feedback This needs a response from the author. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Sep 5, 2023
@aaronliu0130 @stephengillie
make 64 bit
8ce8e66 
Co-authored-by: Stephen Gillie <[email protected]>
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. Needs-Author-Feedback This needs a response from the author. labels Sep 5, 2023
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Sep 6, 2023
@microsoft-github-policy-service
Copy link
Contributor

aaronliu0130,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Sep 6, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit cdb00f1 into microsoft:master Sep 6, 2023
7 checks passed
@microsoft-github-policy-service
Copy link
Contributor

Hello aaronliu0130,
Validation has completed.

Template: msftbot/validationCompleted

@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@aaronliu0130 aaronliu0130 deleted the TaskPlays.TSWModManager-2.2.1-C3AB798A3A3741852A43054DACD2F963D2227E9B branch September 29, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@microsoft-github-policy-service Microsoft GitHub Policy Service microsoft-github-policy-service approved these changes

@stephengillie stephengillie stephengillie approved these changes

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aaronliu0130 @wingetbot @stephengillie @ryfu-msft