Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: nkdAgility.AzureDevOpsMigrationTools.Preview version 15.1.3-Preview.2 #162930

Conversation

MrHinsh
Copy link
Contributor

@MrHinsh MrHinsh commented Jul 14, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jul 14, 2024
Copy link
Contributor

@Trenly Trenly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Command line alias added: "devopsmigration"
Path environment variable modified; restart your shell to use the new value.
Successfully installed

--> Refreshing environment variables

--> Comparing ARP Entries

DisplayName                            DisplayVersion   Publisher                                   ProductCode
-----------                            --------------   ---------                                   -----------
Azure DevOps Migration Tools (Preview) 15.1.3-Preview.2 naked Agility with Martin Hinshelwood & Co. nkdAgility.AzureDevOpsMigrationTools.Preview__...


PS C:\Users\WDAGUtilityAccount\Desktop\winget-pkgs> devopsmigration

Unhandled Exception: System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.Extensions.Hosting.Abstractions, Version=8.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60' or one of its dependencies. The system cannot find the file specified.
   at VstsSyncMigrator.ConsoleApp.Program.<Main>d__0.MoveNext()
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start[TStateMachine](TStateMachine& stateMachine)
   at VstsSyncMigrator.ConsoleApp.Program.Main(String[] args)
   at VstsSyncMigrator.ConsoleApp.Program.<Main>(String[] args)

@MrHinsh - When I attempt to run this program, I get a file not found error. Is there a dependency which is missing?

@MrHinsh
Copy link
Contributor Author

MrHinsh commented Jul 14, 2024

Did you install it under an administrator command prompt?

Portable packages installed under admin don't run as winget does not add the required links. If you uninstall and run under non-admin you should be fine.

I believe this is a know winget issue.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jul 14, 2024
@MrHinsh
Copy link
Contributor Author

MrHinsh commented Jul 14, 2024

I have tested and validated the package. All dependencies are accounted for and everything runs as normal.

image

auto-merge was automatically disabled July 14, 2024 22:27

Head branch was pushed to by a user without write access

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Completed Validation passed Changes-Requested Changes Requested New-Manifest labels Jul 14, 2024
@MrHinsh
Copy link
Contributor Author

MrHinsh commented Jul 14, 2024

OK, so now that dependencies are supported I have added both the .net versions I use..

@MrHinsh
Copy link
Contributor Author

MrHinsh commented Jul 14, 2024

@Trenly i have validated that the "bug" in winget still exists for supporting portable packages installed as "administrator".
Winget under Admin
This has been there since portable packages have been around....

Installing without admin fixes the issue:

Winget normal

I can validate that the application operates as expected and as every previous version does. It should be installed at a normal command prompt and instructions are provided for users. :)

If you know of a manifest change that will fix this I will happily incorporate it (I close the other versions so we can focus on this one).

@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Jul 15, 2024
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Jul 15, 2024
…3-Preview.2/nkdAgility.AzureDevOpsMigrationTools.Preview.locale.en-US.yaml

Co-authored-by: Kaleb Luedtke <[email protected]>
@wingetbot
Copy link
Collaborator

/AzurePipelines run

…3-Preview.2/nkdAgility.AzureDevOpsMigrationTools.Preview.locale.en-US.yaml

Co-authored-by: Kaleb Luedtke <[email protected]>
@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Jul 15, 2024
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Validation-Completed Validation passed Moderator-Approved One of the Moderators has reviewed and approved this PR New-Manifest labels Jul 15, 2024
@MrHinsh
Copy link
Contributor Author

MrHinsh commented Jul 15, 2024

@Trenly I incorporated your changes so another build is running ;)

@MrHinsh
Copy link
Contributor Author

MrHinsh commented Jul 15, 2024

@Trenly it would be great if you could explain how I can create a portable assembly that is statically linked?

The app is a .NET project...

@wingetbot wingetbot added New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jul 15, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jul 15, 2024
@stephengillie stephengillie merged commit 046e2e8 into microsoft:master Jul 15, 2024
8 checks passed
@MrHinsh MrHinsh deleted the nkdAgility.AzureDevOpsMigrationTools.Preview-15.1.3-Preview.2-4d1a068d-725b-41a8-99f7-0358e80e97d6 branch July 15, 2024 17:05
@MrHinsh MrHinsh restored the nkdAgility.AzureDevOpsMigrationTools.Preview-15.1.3-Preview.2-4d1a068d-725b-41a8-99f7-0358e80e97d6 branch July 15, 2024 17:05
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Manifest Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants