Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improvements in monitor queued jobs #19

Merged
merged 7 commits into from
Apr 23, 2024
Merged

Conversation

duhow
Copy link
Contributor

@duhow duhow commented Apr 23, 2024

Queued jobs was picking latest "stored" job, which does not match with queued action we're looking for, as it would later run in_progress but not changed internally.

In order to properly have the job details and check for queued jobs, a refactor is included, and the whole object with full details is stored in memory, deleted after the GitHub job is completed.

Copy link
Contributor

@gerardsegarra gerardsegarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@duhow duhow merged commit 5977cb3 into main Apr 23, 2024
3 checks passed
@duhow duhow deleted the monitor-queued-changes branch April 23, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants