Merge pull request #1644 from mightyiam/class-methods-use-this

feat!: @typescript-eslint/class-methods-use-this
mightyiam · Jul 13, 2024 · 27f8f29 · 27f8f29
2 parents 915bdf0 + 55a6a8c
commit 27f8f29
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 2 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -70,6 +70,15 @@ const rules = {
       },
     },
   ],
+  '@typescript-eslint/class-methods-use-this': [
+    'error',
+    {
+      exceptMethods: [],
+      enforceForClassFields: true,
+      ignoreOverrideMethods: false,
+      ignoreClassesThatImplementAnInterface: false,
+    },
+  ],
   '@typescript-eslint/class-literal-property-style': ['error', 'fields'],
   '@typescript-eslint/consistent-generic-constructors': [
     'error',

diff --git a/src/test/_rules_to_consider.ts b/src/test/_rules_to_consider.ts
@@ -1,5 +1,4 @@
 export const rulesToConsider = [
-  '@typescript-eslint/class-methods-use-this',
   '@typescript-eslint/consistent-return',
   '@typescript-eslint/default-param-last',
   '@typescript-eslint/explicit-member-accessibility',
@@ -70,7 +69,6 @@ export const rulesToConsider = [
   'callback-return',
   'camelcase',
   'capitalized-comments',
-  'class-methods-use-this',
   'complexity',
   'consistent-return',
   'consistent-this',

diff --git a/src/test/_util.ts b/src/test/_util.ts
@@ -106,6 +106,7 @@ export const expectedExportedValue: TSESLint.FlatConfig.Config = {
         checkForEach: false,
       },
     ],
+    'class-methods-use-this': ['off'],
     'constructor-super': ['error'],
     curly: ['error', 'multi-line'],
     'default-case-last': ['error'],
@@ -294,6 +295,15 @@ export const expectedExportedValue: TSESLint.FlatConfig.Config = {
         },
       },
     ],
+    '@typescript-eslint/class-methods-use-this': [
+      'error',
+      {
+        exceptMethods: [],
+        enforceForClassFields: true,
+        ignoreOverrideMethods: false,
+        ignoreClassesThatImplementAnInterface: false,
+      },
+    ],
     '@typescript-eslint/class-literal-property-style': ['error', 'fields'],
     '@typescript-eslint/consistent-generic-constructors': [
       'error',