Skip to content

Commit

Permalink
Merge pull request #1646 from mightyiam/explicit-member-accessibility
Browse files Browse the repository at this point in the history
chore: intentionally not use @typescript-eslint/explicit-member-accessibility
  • Loading branch information
mightyiam committed Jul 13, 2024
2 parents e5b35dc + 9896e79 commit 7177038
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
4 changes: 4 additions & 0 deletions src/_intentionally-unused-rules.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,8 @@ export const intentionallyUnusedRules: string[] = [
// > If possible, it is recommended to use tsconfig's noImplicitReturns option rather than this rule. noImplicitReturns is powered by TS's type information and control-flow analysis so it has better coverage than this rule.
'@typescript-eslint/consistent-return',
'consistent-return',

// From trule documentation:
// > If you are working on a codebase within which you lint non-TypeScript code (i.e. `.js`/`.mjs`/`.cjs`/`.jsx`), you should ensure that you should use [ESLint `overrides`](https://eslint.org/docs/user-guide/configuring#disabling-rules-only-for-a-group-of-files) to only enable the rule on `.ts`/`.mts`/`.cts`/`.tsx` files. If you don't, then you will get unfixable lint errors reported within `.js`/`.mjs`/`.cjs`/`.jsx` files.
'@typescript-eslint/explicit-member-accessibility',
]
1 change: 0 additions & 1 deletion src/test/_rules_to_consider.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
export const rulesToConsider = [
'@typescript-eslint/default-param-last',
'@typescript-eslint/explicit-member-accessibility',
'@typescript-eslint/explicit-module-boundary-types',
'@typescript-eslint/init-declarations',
'@typescript-eslint/lines-around-comment',
Expand Down

0 comments on commit 7177038

Please sign in to comment.