chore: intentionally not use consistent-return

mightyiam · Jul 13, 2024 · dd07dfc · dd07dfc
1 parent 9ae1216
commit dd07dfc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/_intentionally-unused-rules.ts b/src/_intentionally-unused-rules.ts
@@ -1 +1,6 @@
-export const intentionallyUnusedRules: string[] = []
+export const intentionallyUnusedRules: string[] = [
+  // From rule documentation:
+  // > If possible, it is recommended to use tsconfig's noImplicitReturns option rather than this rule. noImplicitReturns is powered by TS's type information and control-flow analysis so it has better coverage than this rule.
+  '@typescript-eslint/consistent-return',
+  'consistent-return',
+]
diff --git a/src/test/_rules_to_consider.ts b/src/test/_rules_to_consider.ts
@@ -1,5 +1,4 @@
 export const rulesToConsider = [
-  '@typescript-eslint/consistent-return',
   '@typescript-eslint/default-param-last',
   '@typescript-eslint/explicit-member-accessibility',
   '@typescript-eslint/explicit-module-boundary-types',
@@ -70,7 +69,6 @@ export const rulesToConsider = [
   'camelcase',
   'capitalized-comments',
   'complexity',
-  'consistent-return',
   'consistent-this',
   'default-case',
   'default-param-last',