Skip to content

Commit

Permalink
Release 4.5.1
Browse files Browse the repository at this point in the history
  • Loading branch information
@miguelgrinberg
miguelgrinberg committed Jul 5, 2023
1 parent 503c865 commit 06ec1a3
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGES.md
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# python-engineio change log

**Release 4.5.1** - 2023-07-06

- Restore support for old versions of eventlet [#321](https://github.com/miguelgrinberg/python-engineio/issues/321) ([commit](https://github.com/miguelgrinberg/python-engineio/commit/503c8651658e26276f3206655a819f79eb25739e))

**Release 4.5.0** - 2023-07-05

- Configure eventlet's websocket max frame length [#319](https://github.com/miguelgrinberg/python-engineio/issues/319) ([commit](https://github.com/miguelgrinberg/python-engineio/commit/1b04a562322a386ef806f1ada73e83d40fa1f0ce))
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[metadata]
name = python-engineio
version = 4.5.0
version = 4.5.1
author = Miguel Grinberg
author_email = [email protected]
description = Engine.IO server and client for Python
Expand Down

6 comments on commit 06ec1a3

@kloczek
Copy link

@kloczek kloczek commented on 06ec1a3 Jul 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible next time on release new version make the github release to have entry on https://github.com/miguelgrinberg/python-engineio/releases? 🤔

I'm asking because only on make gh release is spread notification about new release to those who have set watch->releases.

@miguelgrinberg
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kloczek I have always managed releases with tags, which is not dependent on GitHub. I will look into it, because I need the tag solution. If I can do a release in a addition to tagging, and automatically from my build script, then I'll do it.

@kloczek
Copy link

@kloczek kloczek commented on 06ec1a3 Jul 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not about tags management but purely about spread notifications to those who wants receive it.
Simple github spreads such notification only when /releases entry is added.
Some repos have special .github/workflows file which is used only to make gh release.

@miguelgrinberg
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand, what I'm saying that releases do not help with my own workflow so I cannot drop tags and move to releases. I'll investigate if I can add a release announcement on top of what I'm already doing, that would be the only way I can make this work.

@kloczek
Copy link

@kloczek kloczek commented on 06ec1a3 Jul 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gh release process it is separated thing added on top of existing tag and it can be done at any time😋

@miguelgrinberg
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have 20+ open source packages that I maintain. As I said above, it needs to be scriptable or it won't work for me.

Please sign in to comment.