Skip to content

Commit

Permalink
not necessary to hold the packet queue when upgrading
Browse files Browse the repository at this point in the history
  • Loading branch information
miguelgrinberg committed Mar 16, 2019
1 parent 138fb60 commit 330c6b9
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion engineio/asyncio_socket.py
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,6 @@ async def _websocket_handler(self, ws):
if self.connected:
# the socket was already connected, so this is an upgrade
self.upgrading = True # hold packet sends during the upgrade
await self.queue.join() # flush the queue first

try:
pkt = await ws.wait()
Expand Down
1 change: 0 additions & 1 deletion engineio/socket.py
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,6 @@ def _websocket_handler(self, ws):
if self.connected:
# the socket was already connected, so this is an upgrade
self.upgrading = True # hold packet sends during the upgrade
self.queue.join() # flush the queue first

pkt = ws.wait()
decoded_pkt = packet.Packet(encoded_packet=pkt)
Expand Down

0 comments on commit 330c6b9

Please sign in to comment.