Added logging for websocket upgrade

miguelgrinberg · Jul 13, 2015 · 4b5ceca · 4b5ceca
1 parent 583736a
commit 4b5ceca
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/engineio/socket.py b/engineio/socket.py
@@ -59,6 +59,8 @@ def handle_get_request(self, environ, start_response):
         connections = environ.get('HTTP_CONNECTION', '').lower().split(',')
         transport = environ.get('HTTP_UPGRADE', '').lower()
         if 'upgrade' in connections and transport in self.upgrade_protocols:
+            self.server.logger.info('%s: Received request to upgrade to %s',
+                                    self.sid, transport)
             return getattr(self, '_upgrade_' + transport)(environ,
                                                           start_response)
         try:
@@ -100,6 +102,8 @@ def _websocket_handler(self, ws):
         if pkt != packet.Packet(packet.PING,
                                 data=six.text_type('probe')).encode(
                                     always_bytes=False):
+            self.server.logger.info(
+                '%s: Failed websocket upgrade, no PING packet', self.sid)
             return
         ws.send(packet.Packet(packet.PONG, data=six.text_type('probe')).encode(
             always_bytes=False))
@@ -110,6 +114,8 @@ def _websocket_handler(self, ws):
         pkt = ws.wait()
         if pkt != packet.Packet(packet.UPGRADE).encode(always_bytes=False):
             self.upgraded = False
+            self.server.logger.info(
+                '%s: Failed websocket upgrade, no UPGRADE packet', self.sid)
             return
 
         def writer():
@@ -123,6 +129,9 @@ def writer():
 
         writer_task = eventlet.spawn(writer)
 
+        self.server.logger.info(
+            '%s: Upgrade to websocket succesful', self.sid)
+
         while True:
             p = ws.wait()
             if p is None: