Fix inverted shutdown logic in async service task (Fixes #354)

miguelgrinberg · May 18, 2024 · 8e688ba · 8e688ba
1 parent 942da84
commit 8e688ba
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/engineio/async_server.py b/src/engineio/async_server.py
@@ -524,9 +524,9 @@ async def _service_task(self):  # pragma: no cover
                 try:
                     await asyncio.wait_for(self.service_task_event.wait(),
                                            timeout=self.ping_timeout)
-                except asyncio.TimeoutError:
                     break
-                continue
+                except asyncio.TimeoutError:
+                    continue
 
             # go through the entire client list in a ping interval cycle
             sleep_interval = self.ping_timeout / len(self.sockets)
@@ -546,8 +546,9 @@ async def _service_task(self):  # pragma: no cover
                     try:
                         await asyncio.wait_for(self.service_task_event.wait(),
                                                timeout=sleep_interval)
-                    except asyncio.TimeoutError:
                         raise KeyboardInterrupt()
+                    except asyncio.TimeoutError:
+                        continue
             except (
                 SystemExit,
                 KeyboardInterrupt,